feat: app.embed(defs={'mine': value}) #7146
Draft
+512
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dmadisetti
changed the title
akshayka
reviewed
Nov 11, 2025
akshayka
reviewed
Nov 19, 2025
Comment on lines
834
to
+846
| if not app_kernel_runner.outputs: | ||
| outputs, glbls = await app_kernel_runner.run( | ||
| set(self._execution_order) | ||
| # Inject provided defs into the kernel's globals | ||
| if defs: |
Contributor
There was a problem hiding this comment.
Today app.embed() executes the app once and then serves cached outputs thereafter.
What happens if app.embed() is called with one defs relation, then called again with another defs relation? I think as written in this PR the user will get stale results, because app_kernel_runner.outputs will be non empty.
So, I think we need to retain some kind of cache that is keyed by a tuple of (key, value) pairs in defs.
dmadisetti
force-pushed
the
dm/embed-api
branch
from
1735495 to
ba68668
Compare
dmadisetti
commented
Nov 19, 2025
Comment on lines
+1240
to
+1244
| # Check second result with first override - output then defs | ||
| assert "x is large" in result_override.output.text | ||
| assert "x is small" not in result_override.output.text | ||
| assert result_override.defs["x"] == 100 | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
@akshayka this current fails. Is this the behavior you were thinking of, or a different issue?
Contributor
There was a problem hiding this comment.
Yep, this is an example of the incorrect logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Enables the override of values into embed, allowing for birectional communication of embedded and parent apps