add markdown renderer to popout columns #7202
Draft
+187
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
reviewed
Nov 18, 2025
| wrapped={isWrapped} | ||
| > | ||
| <UrlDetector parts={parts} /> | ||
| {isMarkdown(stringValue) ? ( |
Contributor
There was a problem hiding this comment.
this is expensive to do on each string and likely won't have that many hits. i'd prefer to not do this. was there an issue or reason that sparked this?
Contributor
Author
There was a problem hiding this comment.
No, we don't need to do this, but it does offer a better view for markdown & images in the table
This logic should only trigger when the popup is clicked, so can be optimized (or already is but not obvious..)
Contributor
There was a problem hiding this comment.
isMarkdown seems to be called on call values regardless of being clicked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🔍 Description of Changes
📋 Checklist