Skip to content

fix: base64 encode gzipped data #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: base64 encode gzipped data #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions gothic/gothic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ func GetFromSession(key string, req *http.Request) (string, error) {
session, _ := Store.Get(req, SessionName)
value, err := getSessionValue(session, key)
if err != nil {
return "", errors.New("could not find a matching session for this request")
return "", err
}

return value, nil
Expand All @@ -343,7 +343,8 @@ func getSessionValue(session *sessions.Session, key string) (string, error) {
}

rdata := strings.NewReader(value.(string))
r, err := gzip.NewReader(rdata)
b64Reader := base64.NewDecoder(base64.StdEncoding, rdata)
r, err := gzip.NewReader(b64Reader)
if err != nil {
return "", err
}
Expand All @@ -368,6 +369,6 @@ func updateSessionValue(session *sessions.Session, key, value string) error {
return err
}

session.Values[key] = b.String()
session.Values[key] = base64.StdEncoding.EncodeToString(b.Bytes())
return nil
}
6 changes: 4 additions & 2 deletions gothic/gothic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package gothic_test
import (
"bytes"
"compress/gzip"
"encoding/base64"
"fmt"
"html"
"io/ioutil"
Expand Down Expand Up @@ -274,12 +275,13 @@ func gzipString(value string) string {
return "err"
}

return b.String()
return base64.StdEncoding.EncodeToString(b.Bytes())
}

func ungzipString(value string) string {
rdata := strings.NewReader(value)
r, err := gzip.NewReader(rdata)
b64Reader := base64.NewDecoder(base64.StdEncoding, rdata)
r, err := gzip.NewReader(b64Reader)
if err != nil {
return "err"
}
Expand Down
Loading