Improve robustness of WP-CLI commands and 2FA state cleanup - #5
Open
nimesh-xecurify wants to merge 1 commit into
Open
Improve robustness of WP-CLI commands and 2FA state cleanup#5nimesh-xecurify wants to merge 1 commit into
nimesh-xecurify wants to merge 1 commit into
Conversation
- Validate provider keys in the `disable` command to prevent typos or casing issues from reporting a false success. - Ensure "disable all" clears all residual metadata (secrets, nonces, and throttles) even when the enabled-providers list is already empty. - Add a pre-flight check to backup code generation to avoid storing unusable hashes if the provider cannot be enabled. - Update unit tests and documentation to cover these edge cases and state cleanup behaviors.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disablecommand to prevent typos or casing issues from reporting a false success.