Skip to content

Added dect sorted_variables#3522

Closed
alexandrprokopenko1999-star wants to merge 1 commit into
mate-academy:masterfrom
alexandrprokopenko1999-star:mybranch
Closed

Added dect sorted_variables#3522
alexandrprokopenko1999-star wants to merge 1 commit into
mate-academy:masterfrom
alexandrprokopenko1999-star:mybranch

Conversation

@alexandrprokopenko1999-star
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation has a critical typo on line 19 where the dictionary key is misspelled as "mutale" instead of "mutable". This causes all 9 tests to fail with KeyError: 'mutable' since the tests expect the exact key name "mutable" as specified in [CHECKLIST ITEM #2]. The fix is straightforward — simply change the key from "mutale" to "mutable" on line 19 of app/main.py. Once corrected, all tests should pass since you've correctly categorized all 8 variables (3 mutable: list/dict/set, 5 immutable: int/float/bool/str/tuple) into their respective lists.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread app/main.py
collection_of_coins = {1, 2, 25}

# write your code here
sorted_variables = {"mutale":
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key is misspelled as "mutale" - it should be "mutable" (with 'a', not 'e'). This violates checklist item #2 which requires the key to be exactly "mutable".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants