Update reading output files in FHI-aims SocketIO workflow#1463
Open
ansobolev wants to merge 3 commits intomaterialsproject:mainfrom
Open
Update reading output files in FHI-aims SocketIO workflow#1463ansobolev wants to merge 3 commits intomaterialsproject:mainfrom
ansobolev wants to merge 3 commits intomaterialsproject:mainfrom
Conversation
added 2 commits
April 21, 2026 16:39
…puts rather than ase external interface
Contributor
|
I'm trying to debug/check the socket calcs now |
Collaborator
|
Thanks @ansobolev and @tpurcell90! Let me know when this is ready and I can merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates how atomate2 reads FHI-aims output files for SocketIO calculation flows to be compatible with pyfhiaims ≥ 1.0.
In version 1.0, pyfhiaims.external_interfaces was removed in favor of plugin-based integrations with packages like ASE and pymatgen. Previously, atomate2 used pymatgen.io.aims.outputs.AimsOutput in most cases, but relied on ASE via the pyfhiaims external interface for SocketIO workflows.
This PR removes that inconsistency by switching SocketIO output parsing to also use pymatgen.io.aims.outputs.AimsOutput, aligning it with the rest of the codebase.
See PR #1461 for related CI failures caused by the removal of the external interface.
@tpurcell90, can you check if all is good here?
pymatgen.io.aimsChecklist
Before a pull request can be merged, the following items must be checked:
The easiest way to handle this is to run the following in the correct sequence on
your local machine. Start with running
ruffandruff formaton your new code. This willautomatically reformat your code to PEP8 conventions and fix many linting issues.
Run ruff on your code.
type check your code.
Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit installand a check will be run prior to allowing commits.