add lt_nbhs{r,l} variants#1881
Merged
affeldt-aist merged 1 commit intomath-comp:masterfrom Mar 15, 2026
Merged
Conversation
affeldt-aist
added
the
enhancement ✨
affeldt-aist
force-pushed
the
num_topology_20260305
branch
2 times, most recently
from
31ced05 to
3a532a7
Compare
Member
Author
|
@CohenCyril do you think these additions make sense or the fact that their proof is a mere application of two lemmas is an indication that we should postpone this PR? |
affeldt-aist
force-pushed
the
num_topology_20260305
branch
from
3a532a7 to
d7ad040
Compare
affeldt-aist
force-pushed
the
num_topology_20260305
branch
from
d7ad040 to
dedd3b1
Compare
Member
Author
|
I will maybe merge in the interest of the release, on the basis that we have at least one use case for these lemmas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
realFieldType#1879Motivation for this change
Checklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers