Show success notification once a Goal has been created or updated #23809
+230
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f adding the segment into the store to finish before we 'mark' icons as 'compared'
…of 'data_comparison_segment_limit' to include the count for the first segment to compare (Usually 'All Visits').
… will stop click events on the element
…lick event to 'markCurrentSegment'
…se this does not allow us to show the notifications. We now just load the new goals by calling via api and updating the view
…. This makes it faster as well as being able to show the notification
…props if not found in goals list
fixing test
tzi
reviewed
Nov 24, 2025
tzi
reviewed
Nov 24, 2025
tzi
reviewed
Nov 24, 2025
nathangavin
previously approved these changes
Nov 25, 2025
Contributor
nathangavin
left a comment
nathangavin
left a comment
There was a problem hiding this comment.
Looks good to me, nice cleanup on the refresh of the goals list on goal creation.
Contributor
|
There is 2 diff from the UI screenshot that seems to be legit: |
sgiehl
reviewed
Nov 27, 2025
mneudert
requested changes
Dec 1, 2025
…cations after we have reloaded the page
mneudert
reviewed
Dec 2, 2025
| }); | ||
| let successMessage = translate(isCreate ? 'Goals_GoalCreated' : 'Goals_GoalUpdated'); | ||
| const reportLink = `<a href="?${link}#${hash}">[${translate('Goals_ViewGoalReport')}]</a>`; | ||
| successMessage = `<div class="notification-message">${successMessage} ${reportLink}</div>`; |
Member
There was a problem hiding this comment.
Suggested change
| successMessage = `<div class="notification-message">${successMessage} ${reportLink}</div>`; | |
| successMessage = `${successMessage} ${reportLink}`; |
In the UI test you can access the message using .notification-body, if that was the sole reason for this additional div.
Comment on lines
+667
to
+668
| this.storeNotification(idToUse, isCreate); | ||
| this.showNotificationMessage(idToUse, isCreate); |
Member
There was a problem hiding this comment.
Is flashing the notification and then doing a full page reload the wanted behaviour? Or should it only be stored here and then shown on the target page?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UX-333
Currently, when a Goal is edited and saved, no feedback is shown to the user.
After a Goal is successfully updated, display a success message at the top of the page.
Acceptance criteria:
Show a confirmation message like:
“Goal successfully updated. [View Goal Report]”
The “View Goal Report” link should direct to the corresponding Goal report page.
Checklist
Review