Change changes_requested text to requested changes#1323
Open
adarsh3410 wants to merge 1 commit into
Open
Conversation
Half-Shot
requested changes
Jun 11, 2026
Half-Shot
left a comment
Half-Shot
left a comment
Contributor
There was a problem hiding this comment.
You will also need to sign off the changes please :)
adarsh3410
force-pushed
the
fix-changes-requested-text
branch
from
a607b35 to
c4ae58f
Compare
Author
|
Thanks for the feedback! I've updated the PR to keep the existing formatting and only change the |
Half-Shot
requested changes
Jun 11, 2026
| }[event.review.state.toLowerCase()]; | ||
| const reviewState = event.review.state.toLowerCase(); | ||
|
|
||
| const emojiForReviewMap: Record<string, string> = { |
Contributor
There was a problem hiding this comment.
Indent looks wrong to me, you probably need to run pnpm run lint:js:apply
| reviewState === "changes_requested" | ||
| ? "requested changes" | ||
| : reviewState | ||
| } ${orgRepoName}#${event.pull_request.number}` |
Contributor
There was a problem hiding this comment.
This is still missing the title and other parts
|
|
||
|
|
||
|
|
||
| const content = emojify( |
Contributor
There was a problem hiding this comment.
I don't think you need any of these 5 newlines.
Signed-off-by: Adarsh Reddy <adarshreddy914@gmail.com>
adarsh3410
force-pushed
the
fix-changes-requested-text
branch
from
c4ae58f to
a620225
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the GitHub review state text from
"changes_requested"
to
"requested changes"
to improve readability of review notifications.
Fixes #363