feat(room_list): make RoomListService updates subscriptions non-destructively#6652
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6652 +/- ##
==========================================
+ Coverage 89.86% 89.88% +0.01%
==========================================
Files 396 396
Lines 110260 110360 +100
Branches 110260 110360 +100
==========================================
+ Hits 99088 99197 +109
+ Misses 7395 7389 -6
+ Partials 3777 3774 -3 ☔ View full report in Codecov by Harness. |
Johennes
commented
Jun 8, 2026
09183ba to
8c866a4
Compare
81d3130 to
7e789cc
Compare
Hywan
requested changes
Jun 23, 2026
Hywan
requested changes
Jun 25, 2026
Hywan
requested changes
Jun 29, 2026
Hywan
left a comment
Member
There was a problem hiding this comment.
I think we are good! You can rebase your fixup commits, and expand the changelog description a bit, and I'll be happy to merge i!t
…uctively Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
ce12ff1 to
f54d6c6
Compare
Contributor
Author
|
Sorry for the delay in getting this patched up. I have extended the changelog and rebased all the fixups away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With my Filament hat on.
Fixes: #6620
(see Writing changelog entries).