Skip to content

feat(room_list): make RoomListService updates subscriptions non-destructively#6652

Merged
Hywan merged 1 commit into
matrix-org:mainfrom
Johennes:johannes/resubscribe-rooms
Jul 3, 2026
Merged

feat(room_list): make RoomListService updates subscriptions non-destructively#6652
Hywan merged 1 commit into
matrix-org:mainfrom
Johennes:johannes/resubscribe-rooms

Conversation

@Johennes

@Johennes Johennes commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

With my Filament hat on.

Fixes: #6620

  • I've documented the public API changes in the appropriate changelog files
    (see Writing changelog entries).
  • This PR was made with the help of AI.

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.19048% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.88%. Comparing base (7b2b439) to head (f54d6c6).
⚠️ Report is 62 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/sliding_sync/mod.rs 96.15% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6652      +/-   ##
==========================================
+ Coverage   89.86%   89.88%   +0.01%     
==========================================
  Files         396      396              
  Lines      110260   110360     +100     
  Branches   110260   110360     +100     
==========================================
+ Hits        99088    99197     +109     
+ Misses       7395     7389       -6     
+ Partials     3777     3774       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Comment thread crates/matrix-sdk/src/sliding_sync/mod.rs
@codspeed-hq

codspeed-hq Bot commented Jun 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing Johennes:johannes/resubscribe-rooms (f54d6c6) with main (cc670dc)

Open in CodSpeed

@Hywan Hywan self-requested a review June 9, 2026 08:42
@Johennes Johennes force-pushed the johannes/resubscribe-rooms branch from 09183ba to 8c866a4 Compare June 22, 2026 18:59
@Johennes Johennes changed the title fix(sliding_sync): avoid resubscribing existing subscriptions feat(room_list): make RoomListService updates subscriptions non-destructively Jun 22, 2026
@Johennes Johennes force-pushed the johannes/resubscribe-rooms branch 2 times, most recently from 81d3130 to 7e789cc Compare June 22, 2026 19:02
@Johennes Johennes marked this pull request as ready for review June 22, 2026 19:07
@Johennes Johennes requested a review from a team as a code owner June 22, 2026 19:07

@Hywan Hywan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Almost there!

Comment thread crates/matrix-sdk/src/sliding_sync/mod.rs Outdated
Comment thread crates/matrix-sdk/src/sliding_sync/mod.rs Outdated
Comment thread crates/matrix-sdk/src/sliding_sync/mod.rs Outdated
@Johennes Johennes requested a review from Hywan June 23, 2026 18:26
@Johennes Johennes requested a review from Hywan June 25, 2026 18:50

@Hywan Hywan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are good! You can rebase your fixup commits, and expand the changelog description a bit, and I'll be happy to merge i!t

Comment thread crates/matrix-sdk/changelog.d/6652.added.md
…uctively

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes force-pushed the johannes/resubscribe-rooms branch from ce12ff1 to f54d6c6 Compare July 2, 2026 17:23
@Johennes

Johennes commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Sorry for the delay in getting this patched up. I have extended the changelog and rebased all the fixups away.

@Johennes Johennes requested a review from Hywan July 2, 2026 17:24

@Hywan Hywan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Hywan Hywan merged commit 75bfc1c into matrix-org:main Jul 3, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RoomListService::subscribe_to_rooms behaviour when resubscribing to the same rooms

2 participants