Skip to content

Tests for the #[export] macro#6691

Open
andybalaam wants to merge 2 commits into
mainfrom
andybalaam/test-export-macro
Open

Tests for the #[export] macro#6691
andybalaam wants to merge 2 commits into
mainfrom
andybalaam/test-export-macro

Conversation

@andybalaam

Copy link
Copy Markdown
Member

I thought there was a bug in the #[export] macro so I wrote some tests. It seems to be fine, but the tests are hopefully still useful.

  • This PR makes no API changes so needs no changelog entry
  • No AI was used to make this PR

@andybalaam andybalaam requested a review from a team as a code owner June 25, 2026 16:32
@andybalaam andybalaam requested review from stefanceriu and removed request for a team June 25, 2026 16:32
@andybalaam

Copy link
Copy Markdown
Member Author

@poljar is it OK for me to set tests = true in bindings/matrix-sdk-ffi-macros/Cargo.toml? (This PR does that, so I can run the tests.)

@poljar

poljar commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@poljar is it OK for me to set tests = true in bindings/matrix-sdk-ffi-macros/Cargo.toml? (This PR does that, so I can run the tests.)

I think you can also just remove that line, yes it's fine.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@023f5bd). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6691   +/-   ##
=======================================
  Coverage        ?   89.94%           
=======================================
  Files           ?      397           
  Lines           ?   110656           
  Branches        ?   110656           
=======================================
  Hits            ?    99530           
  Misses          ?     7357           
  Partials        ?     3769           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing andybalaam/test-export-macro (e138043) with main (023f5bd)

Open in CodSpeed

@andybalaam andybalaam enabled auto-merge (rebase) June 29, 2026 10:50
@andybalaam andybalaam disabled auto-merge June 29, 2026 10:50
@andybalaam andybalaam enabled auto-merge (rebase) June 29, 2026 10:51
@andybalaam andybalaam force-pushed the andybalaam/test-export-macro branch from 55750c4 to 48b1235 Compare June 29, 2026 10:52
@andybalaam andybalaam force-pushed the andybalaam/test-export-macro branch from 48b1235 to e138043 Compare June 30, 2026 10:52
@andybalaam andybalaam disabled auto-merge June 30, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants