Skip to content

fix(sdk): Loosen reqwest feature flags to avoid pulling aws-lc-sys#6706

Open
procr1337 wants to merge 1 commit into
matrix-org:mainfrom
procr1337:remove-reqwest-feature-flag
Open

fix(sdk): Loosen reqwest feature flags to avoid pulling aws-lc-sys#6706
procr1337 wants to merge 1 commit into
matrix-org:mainfrom
procr1337:remove-reqwest-feature-flag

Conversation

@procr1337

@procr1337 procr1337 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Previously, matrix-sdk would pull aws-lc-sys as a transitive dependency via reqwest's rustls feature, even if downstream users otherwise rely on ring. rustls-no-provider is the provider-agnostic alternative, which is now used instead.

This is a breaking change because downstream users now have to pick a provider explicitly, via a reqwest feature flag or by manually registering a rustls provider.

If preferred, we can introduce a new feature flag for the previous behavior, and make it a default. That way it can be deselected manually.

  • I've documented the public API changes in the appropriate changelog files
  • This PR was made with the help of AI.

@procr1337 procr1337 force-pushed the remove-reqwest-feature-flag branch from dd66584 to eb3f582 Compare June 30, 2026 20:59
@procr1337 procr1337 marked this pull request as ready for review June 30, 2026 21:10
@procr1337 procr1337 requested a review from a team as a code owner June 30, 2026 21:10
@procr1337 procr1337 requested review from poljar and removed request for a team June 30, 2026 21:10
@codspeed-hq

codspeed-hq Bot commented Jun 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 27 untouched benchmarks
⏩ 23 skipped benchmarks1


Comparing procr1337:remove-reqwest-feature-flag (59a9e28) with main (023f5bd)

Open in CodSpeed

Footnotes

  1. 23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@023f5bd). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6706   +/-   ##
=======================================
  Coverage        ?   89.94%           
=======================================
  Files           ?      397           
  Lines           ?   110656           
  Branches        ?   110656           
=======================================
  Hits            ?    99530           
  Misses          ?     7354           
  Partials        ?     3772           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Signed-off-by: Procr <193802945+procr1337@users.noreply.github.com>
@procr1337 procr1337 force-pushed the remove-reqwest-feature-flag branch from eb3f582 to 59a9e28 Compare July 1, 2026 07:19
@procr1337 procr1337 changed the title fix(matrix-sdk): Loosen reqwest feature flags to avoid pulling aws-lc-sys fix(sdk): Loosen reqwest feature flags to avoid pulling aws-lc-sys Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant