fix(sdk): Loosen reqwest feature flags to avoid pulling aws-lc-sys#6706
Open
procr1337 wants to merge 1 commit into
Open
fix(sdk): Loosen reqwest feature flags to avoid pulling aws-lc-sys#6706procr1337 wants to merge 1 commit into
procr1337 wants to merge 1 commit into
Conversation
dd66584 to
eb3f582
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6706 +/- ##
=======================================
Coverage ? 89.94%
=======================================
Files ? 397
Lines ? 110656
Branches ? 110656
=======================================
Hits ? 99530
Misses ? 7354
Partials ? 3772 ☔ View full report in Codecov by Harness. |
Signed-off-by: Procr <193802945+procr1337@users.noreply.github.com>
eb3f582 to
59a9e28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, matrix-sdk would pull aws-lc-sys as a transitive dependency via reqwest's rustls feature, even if downstream users otherwise rely on ring. rustls-no-provider is the provider-agnostic alternative, which is now used instead.
This is a breaking change because downstream users now have to pick a provider explicitly, via a reqwest feature flag or by manually registering a rustls provider.
If preferred, we can introduce a new feature flag for the previous behavior, and make it a default. That way it can be deselected manually.