feat(search): index media, stickers, polls and more message types#6710
Open
stefanceriu wants to merge 1 commit into
Open
feat(search): index media, stickers, polls and more message types#6710stefanceriu wants to merge 1 commit into
stefanceriu wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6710 +/- ##
==========================================
+ Coverage 89.91% 89.94% +0.02%
==========================================
Files 396 396
Lines 110609 110800 +191
Branches 110609 110800 +191
==========================================
+ Hits 99454 99656 +202
+ Misses 7378 7360 -18
- Partials 3777 3784 +7 ☔ View full report in Codecov by Harness. |
Previously the search index only handled plain-text `m.room.message` events and everything else hit `MessageTypeNotSupported` and was silently dropped. This decouples the index from Ruma event types and broadens coverage with the search crate now being content-agnostic. `RoomIndexOperation::Add/Edit` carry a new `IndexableEvent` instead of `OriginalSyncRoomMessageEvent` and `make_doc` builds a document straight from that struct. The logic for extracting the text from the messages is now within the main SDK crate. Types added: * Image, Video, Audio and File for filename + caption * Emote, Notice and ServerNotice for body * Location for description * Sticker for Sticker and alt text * and finally Polls for question and answers
163fcbe to
30c30ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the search index only handled plain-text
m.room.messageevents; everything else hitMessageTypeNotSupportedand was silently dropped.This decouples the index from ruma event types and broadens coverage with the search crate now being content-agnostic.
RoomIndexOperation::Add/Editcarry a newIndexableEventinstead ofOriginalSyncRoomMessageEventandmake_docbuilds a document straight from that struct. The logic for extracting the text from the messages is now within the main SDK crate.Types added: