Skip to content

feat: Add lockfile and locking script #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matthewfeickert wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Add lockfile and locking script #5

matthewfeickert wants to merge 6 commits into from

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 12, 2023

  • Move environment definition file to top level directory.
  • Add conda-lock lock script that uses Docker and conda-lock to build a conda-lock lock file and then move it to binder/environment.yml to serve as the conda config file for Binder.
  • Add built lock file.

@matthewfeickert matthewfeickert added the enhancement New feature or request label Oct 12, 2023
@matthewfeickert matthewfeickert self-assigned this Oct 12, 2023
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Oct 12, 2023 •
edited
Loading

Ah this won't work as BinderHub wants binder/environment.yml to be a normal environment definition file and not a conda-lock file

EnvironmentSectionNotValid: The following sections on '/home/jovyan/binder/environment.yml' are invalid and will be ignored:
 - version
 - metadata
 - package

(Reported this as jupyterhub/repo2docker#1312)

@matthewfeickert
feat: Add lockfile and locking script
e915eff 
* Move environment definition file to top level directory.
* Add conda-lock lock script that uses Docker and conda-lock to
  build a conda-lock lock file and then move it to binder/environment.yml
  to serve as the conda config file for Binder.
* Add built lock file.
@matthewfeickert
Update lock to just use normal lockfile name
12da9cc
@matthewfeickert
Install into local environment
0d18239
@matthewfeickert matthewfeickert mentioned this pull request Oct 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@matthewfeickert matthewfeickert

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewfeickert