forked from sony/nmos-cpp
-
Notifications
You must be signed in to change notification settings - Fork 0
LLDP: enable configuration on the fly #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maweit
wants to merge
481
commits into
master
Choose a base branch
from
lldp-rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump OpenSSL to 1.1.1n
Add pplx::observe_exceptions Add pplx::details::wait_nothrow
Fixes Visual Studio build
…oid task result type and simplify usage
Resolve crash in nmos::server::close
Output GitHub job summary for "AMWA test suite" step
* Apply patch for non-constant SIGSTKSZ See https://src.fedoraproject.org/rpms/catch1/blob/rawhide/f/catch1-sigstksz.patch * Try Ubuntu 22.04 * Don't set CMAKE_CXX_STANDARD * Try Ubuntu 22.04 * Document Ubuntu 22.04
* Add discovery_mode setting to enable Registration API connections using host names instead of IP addresses * Remove the likely pointless discovery_mode_both
Updated NmosCppConan.cmake and Dependencies.md for conan supported versions
(except lukka/get-cmake@latest is currently v3.23.0)
Bump nlohmann/json to 3.10.5
… 2110-20:2022 requires it to be omitted
Relax fmtp requirement for whitespace after semicolon
… references to RFC 9134 and ST 2110-20:2022 where appropriate
…parameter constraint
…aint and add function to calculate format bit rate
…tifact (sony#410) Version up download-artifact and upload-artifact upload-artifact: v1 -> v3.0.0 download-artifact: v2.0 -> v4.1.8
GitHub actions: Version up deprecated upload-artifact and download-artifact REDUX
* Improve reporting and logging of errors * Fix constraint validation of enum sequences and struct sequences * Return NcMethosResultError instead of NcMethodResult --------- Co-authored-by: Simon Lo <[email protected]>
IS-12: Fix datatype constraints check for NcDatatypeDescriptorStruct
IS-12: Ensure NcMethodResultError returned on error (not NcMethodResult)
… from 'slog::detail::`anonymous-namespace'::log<`anonymous-namespace'::dull_gate,-2147483647>' to 'slog::log_statement &' message : A non-const reference may only be bound to an lvalue
Fix slog warning
…ny#421) * Remove redundant NodeJS switch * Upgrade macOS from -12 to -13 * Remove Ubuntu-14.04 & macOS workflow
* Add jwt client assertion restrictions and tests * Replace `system_clock` with `steady_clock` when calculating the response time * Tidy up
Use if_indextoname to log the interface name for DNS-SD functions
"caps" is required for all Receivers
…unctions (sony#426) * Refactor handling of required format-specific parameters * Remove potential misleading error message Since an 'empty' fmtp attribute would appear the same at this abstraction, it's better to rely on reporting omission of specific required format-specific parameters * Switch if-else branches for consistency between required and optional parameters * Add _or_defaults versions of the functions that normally throw when required parameters are omitted - these functions still throw if they encounter invalid values
fix bad link
Starting January 30th, 2025, GitHub Actions no longer be able to use v3 of actions/upload-artifact or actions/download-artifact
Update README.md
IS-12: Fix remove_sequence_item control protocol method
`make_lldp_manager` is implemented as a lambda and receives a list of host interfaces at creation of the handler. If i.e. the IP address of an interface changes the lldp-manager has to destroyed and recreated. By re-reading the `host_interfaces` from the `model.settings` this can be avoided and `configure_interfaces` can be called instead.
maweit
pushed a commit
that referenced
this pull request
Oct 31, 2025
Added /rolePaths/{rolePath}/properties endpoint
Co-authored-by: Simon Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_lldp_manageris implemented as a lambda and receives a list of host interfaces at creation of the handler. If i.e. the IP address of an interface changes the lldp-manager has to destroyed and recreated. By re-reading thehost_interfacesfrom themodel.settingsthis can be avoided andconfigure_interfacescan be called instead.