Conversation
|
The changes must be as minimal as possible. Add your CI without any unnecessary changes to existing code, please. Do more with less. |
|
The macOS with cmake fails as expected because of |
I was planning to do that, but the current CI setup is quite complex, a refactoring is necessary. CI for makefile is copied from old file. |
|
One more important reason for me to make these changes is that the current division of CI based on the build system is not reasonable. If more platforms are added in the future, such as FreeBSD or MinGW, it will be very difficult to expand CI on the existing basis. The build system should be regarded as one dimension in the matrix. |
|
I forgot to update the badge link in the README. I will update this pr later. By the way, compared to showing the CI status under different build systems, it is obviously more reasonable to display the build status of different platforms. |
b3be811 to
b769e20
Compare
There are 3 different build systems. Not one. Squash your commits and force-push them, to make your changes review friendly, please. |
Done |
|
This PR still deletes the existing CI files and creates new ones. This discards the change history of the deleted files. The diff is the entire new file. Such PRs are universally unacceptable, I am afraid. |
No offense intended, it sounds very funny. The reasons for making these changes have been explained very clearly. The improvement is obvious. If you do have some practical suggestions, then I would be more than willing to make the necessary changes. However, I won't waste any more time here. |
Proposing changes to third-party libraries just to work around a problem Apple conjured out of thin air is peak absurdist comedy. Everyone these days fancies themselves a comedian, it feels.
This will keep happening with your PRs until you learn to actually listen to feedback, undo your mistakes, and make your changes truly elegant -- simple, clean, and powerful. You'll start becoming an adult the day you learn to self-verify and self-correct. Have a wonderful Sunday, dear Weihang. Maxim |
|
You never collaborate with anyone, am I right? Because you neither accept the improvement nor can you provide any effective suggestions.
Never mind, it took me a cup of coffee to remove all references to this library from my team 😁
Don't forget to format your code with clang-format, you mentioned it in README 😁 |
Did you notice that your PR is not the first but rather an ironic #101? That's the Universe laughing here.
Print my round profile photo and throw darts at it with your team. If that's any consolation.
That got out of date and should be removed, thank you for reminding me that. |
No, I don't have such a habit. You can't possibly think I'm angry, can you?
You're welcome. Don't forget to add CI for Risc-V LoongArch and so on, They are obviously much more important than macOS in terms of support. I'm thinking about seeing what these ci will end up like. Just curious. One more thing, I sincerely suggest that you remove those three silly badges from the README, it seems like you are testing these three build systems. You don't need to thank me again. |
This is the funniest joke I've ever heard. You should not delete any files in the repository, by the way, including .clang-format, as it will result in the loss of history. |
|
You can just create a new file with your alternative cross-platform CI without breaking anything existing. That would take less effort than typing your tantrums and achieve your desired outcomes. This option remains available for you, you are welcome to change your mind at any time. |
I couldn't find a way to create a url that refers to the latest CI run for a particular platform. |
This is impossible to happen. |
Let it sink. Sleep over it. It will grow on you, I guarantee 💯👌🏼😁 |
You will find answer in this pr. 😆 |
There is no reason to bundle the break with your thing. Just create the new thing which obsoletes existing things, without ever touching or breaking them. Or, is that another impossible thing for you? |
Guess what. |
Another rainy day for Objective-C++? |
Rewritten CI from scratch
cmake,meson,makefileon ubuntucmake,mesonon macOScmakeon windows