Roasty's palette gets a home, and its mood marks follow the mood - #510
Merged
Conversation
4 tasks
# Conflicts: # docs/CHANGELOG.md # lib/features/companion/presentation/roasty.dart
# Conflicts: # docs/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #424.
Visible change. In Dark Roast, Roasty's sleeping
zs were the light mood's grey on the dark canvas, and the wrong-answer badge was the light mood's red. The mascot component (prototype/roasty.jsx) gives those to--ink-muteand--berry, and the module stars, rays and two sparkles to--warn. TheRoastywidget now handscontext.moodto its painter and those marks read it — so in Cupping the stars go from#C8843Ato the mood's warn#9A5F1C, and the badge from#B8533Ato berry#A8362A. This is the thing to look at in a screenshot, in both moods.The palette.
RoastyColorsholds the 15 colours that are fixed in both moods: the ten the design page names in its/* Roasty palette */block, and the five the drawings use unnamed. Same shape asArtColors; the unthemed guard lists it.Guards.
roasty_colors_test.dartreads the palette block offprototype/Mascot - Roasty.htmland the unnamed literals offroasty.jsx, and fails anyColor(0x…)underlib/features/companion.roasty_painters_mood_test.dartpaints onto a recording canvas and checks each mood-following mark uses its own mood's value and not the other's.Also here. The happy face's right cheek was at 0.45 against the left's 0.55; both are the design's 0.55 now. Two prototype citations in
roasty.dartare gone. The face-geometry gaps found on the way are #506.Checks.
tool/check_changelog.sh,dart format --set-exit-if-changed,flutter analyze, the metrics gate andflutter testpass locally.