The six full-screen flows wear the design's floating bar; About opens on the app - #554
Merged
Conversation
Five conflicts, four of them the same comments shortened two ways by the comment cap — main's wording is kept in each. The fifth is the changelog, where both sides added bullets under Changed; both are kept. The lesson screen's card call took main's new `seed: cardSeed(...)` shape through the auto-merge, which is why the bar work and the recall payoff sit together cleanly.
This was referenced Sep 8, 2026
…very bar The word *Mini-game* left the bar with the title and landed nowhere. The design opens that body on it and files the module the game drills on the catalog row that reached it, so the kicker says what kind of thing this is. `FloatBarScaffold` replaces the `Stack` and `Positioned` each of the six screens had copied, so a flow now reads as its bar over its page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #525 and #527.
The six full-screen flows drop Material's bar for
FloatTopbar, now on the design's32px 1fr 32pxgrid with a centre and a trailing slot, held over the page by oneFloatBarScaffold. A lesson, a mini-game and both drills seal from the first frame — the page's own colour through the status-bar band, hairline under, content passing beneath. The mini-game intro and Term of the Day show nothing until their content moves, then take the header fill and blur that Settings and the Atlas already wear. The intro's body opens onMINI-GAME, which is where the design keeps a screen's name and where the word went when the bar's title came out. About opens on Roasty,BrewPathand the tagline, centred; the other three screens behind Settings share the frame unchanged.#525's body was wrong, and is rewritten. It said the design floats all six, transparent at rest. The running prototype draws four of them solid and two permanently transparent, so building to the ticket would have moved four screens away from the design. The owner confirmed an uncommitted design update — the two formerly-transparent screens now share the scroll-aware bar, and all six seal the band, four always and two on scroll — and that is what this builds.
One thing left undone, filed as #561 (backlog).
vocab_game_screen.dartis 314 lines, and the length is a symptom: flashcards keeps its progression in a value it can unit-test, and Guess the term keeps its in theState. That asymmetry predates this branch, which touched 22 lines of the file to swap its bar.Checks:
dart format,flutter analyze, the metrics gate, the comment check, the changelog check and the full suite (2815) pass. All four screens were driven on a simulator and read against the design, which caught three defects no test could see: About's blurb left-aligned where the design centres it, every run opening a gutter low because the bar's room was added to each scroll's own padding, and — with the review — the mini-game results view given no room at all and sitting under the bar.