The Tour's first card no longer opens under the clock - #558
Merged
Conversation
The Tour's card takes the side of its target the design names when it fits there, and the other side when it does not. The design is drawn against a mock with no status bar, so its side rule could not see that above a tall Today card there is only the status bar's strip left — on a phone the first stop drew behind it, with the time struck through the title. Placement moves into tourCardTop, which needs the card's own height, so the slot is laid out rather than Positioned.
Both sides added a Fixed bullet; both stand.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the guide layer against
guide.jsxfor #336, then drove all four Tour stops on a wiped iPhone 16.The layer is faithful. Copy, geometry, the frame's radius, ring and 320ms move, the card's padding, leading and controls, the seven micro-tips and the seven App Guide sections all match the design. One divergence is deliberate and already recorded (the Streak section's first sentence, under #338's ruling).
One defect, only visible on a real phone. The Tour's first card opened behind the status bar, with the clock struck through "One lesson a day." The design's side rule sends the card above a target with less than 330 below it; the Today card is tall and starts near the top, so "above" is only the status bar's strip. The mock the rule is drawn against has no status bar, so nothing in the rule — and no assertion in the suite — could see it.
The card now takes the design's side when it fits there and the other side when it does not. At stop 1 it drops below the Today card: nothing hidden, nothing under the clock. Stops 2–4 are unchanged, because the design's side already fits at each. Clamping instead was tried first and rejected — it kept the card on screen but left it covering the CONTINUE LEARNING heading of the card it introduces. Owner ruled the side swap over the clamp.
Placement needs the card's own height to know which sides fit, so it moved out of
PositionedintotourCardTop— pure, and unit-tested for both sides, both safe edges, the resting state, and a target too tall for either side.Not touched: #536 (the stops' copy) and #537 (whether the Tour asks before it runs) remain yours to rule on.
dart format,flutter analyze, metrics, the comment cap and 2809 tests pass. All four stops driven end to end on the simulator.