Settings: hide the reminder rows until reminders exist (#443) - #559
Merged
Conversation
4 tasks
Ruled on #443: daily reminders are not in the v1 launch and are built next. The Notifications switch and the Daily reminder time row stored a preference nothing read — no reminder has ever been scheduled — and a switch that stores a wish is the inert row the repo forbids. The stored preference, the sheet and the reminder domain stay for #443. The ruling is recorded in docs/design/09-deferred-v2.md.
maximsan
force-pushed
the
chore/hide-reminder-rows
branch
from
September 9, 2026 09:25
6c73192 to
59a93c3
Compare
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruled on #443 (8 Sep): daily reminders are not in the v1 launch and are built next. Until then the two
PRACTICErows that belong to them, the Notifications switch and the Daily reminder time row, are hidden. They stored a preference nothing read: no reminder has ever been scheduled, and a switch that stores a wish is the inert row the repo forbids (#448, #531). The stored preference, the sheet and the reminder domain stay for #443.The ruling is recorded in
docs/design/09-deferred-v2.mdin the same change.Driven on an iPhone 17e simulator and reviewed:
PRACTICEshows Sound effects and Haptics only, with the section spacing unchanged. No image kept, per the screenshot rule.dart format,flutter analyze, the comments check, the metrics gate and the widget tests pass; the settings test now asserts the two rows are absent.