fix: letter six count lines at the widths the design gives them - #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #551, which lettered the four count lines a table happened to name. The
table was never the boundary: the design states a letter spacing at each site,
so the check is every mono count line in
lib/read against the design's ownvalue. Six more were taking their rung's width instead of their own.
01 / 05position counter, lesson and mini-game playerN / NCORE LESSONS COMPLETEDcountNEXT · <stage>Hazards
axis tokens carry them. Reading each site rather than assuming
countis what kept the tree lines from being lettered 0.04em too tight.
through
theme.textTheme, which drew the count in the control face on thesupport rung and the kicker in mono. Both now go through
AppText, and thekicker through
SmallcapsLabellike every other kicker.NEXT · <stage>stops being aSmallcapsLabel. The design draws it mono at0.1em, not by the smallcaps rule — so it keeps its own
Semanticslabel withthe original casing, which is what
SmallcapsLabelwas giving it.On #555. It listed three leftovers and is closed as mis-filed, not closed
by this PR. Two of its three lines are fixed here. The third — the How to
play drawer's
01 02 03— is not a line the app draws at all: those are thedrawer's instructions, not lesson steps, and #550 owns building the drawer and
now names their 0.06em in its criteria.
Checks
flutter analyze,dart format, metrics, comment cap and changelog: clean.flutter test: 2,860 passing.six fails exactly six tests, and no others.