feat(lessons): a card names its format, and the ? explains how to play it (#550) - #565
Merged
Conversation
…y it (#550) The ten kinds the design writes help for open on their cue in the accent, with a ? beside it that opens the how-to-play drawer on the bundled bank. The five kinds carrying an authored eyebrow are untouched. CardCue's ten values are exactly the ten kinds with help, and its helpKey is the bank's key, so a ? over nothing is unrepresentable rather than guarded against. The concept card branches as the design does: the fill cue only where the card has blanks. The cue sets smallcaps at the support rung and the drawer numbers its steps at 0.06em, neither of which the tracking axis could say, so it gains those two steps. The sheet primitive gains an eyebrow, because the design puts How to play above the drawer's title. The drawer's per-kind icon well is not ported: marks exist for seven of the ten kinds, and seven filled wells beside three empty ones is the fault #436 already ruled out. Registered in the design's open items.
…mark that drifted right AppTracking.token duplicated count(0.06), which landed on main while this branch was open; the drawer's step numbers use count and the duplicate is gone. The mark sat at the card's trailing edge because the phrase took Expanded, where the design puts it 8px after the last letter. The cue also carries lineHeight: 1, its foot is the ladder's 12 rather than an off-token that equalled it, and the step stack opens at the design's 20. Two divergences registered rather than left silent: the cue line is taller than the design's, because Flutter cannot reproduce the button's negative-margin bleed without shrinking the 44 target it exists to protect; and match's cue says drag to pair where the app's board only taps. Also: three doc comments orphaned by deleting the old _cue consts, a test fake that stubbed one method while the other read the real bundle, and phrase assertions covering seven kinds of ten.
…troduced The cue makes CardShell read a provider, and this file pumps MatchBoardView bare. It sits in test/widget/ rather than test/widget/features/lessons/, so the sweep that scoped the other three card tests missed it and CI caught it.
The match cue was recorded as a divergence to live with. It is not — the design's board drags and draws a line into each answer, and the app's does neither, so the cue is right and the board is the gap (#566). The missing icon well is #567, which draws the three marks that block it. What is left in the table is the one with no action: the cue line is taller than the design's because Flutter cannot hit-test outside a parent box, so the 44 target wins.
# Conflicts: # lib/features/lessons/presentation/cards/concept_card_view.dart # lib/features/lessons/presentation/cards/multi_card_view.dart # lib/shared/theme/off_token.dart # test/widget/features/lessons/content_card_view_test.dart
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #550 — the ten kinds with help open on their cue, and the
?explains them.Hazards
CardShellnow reaches for a provider. The?needs the bundled help bank, soCardCueRowholds aConsumerWidget. Four existing test files gained aProviderScope; one of them, the narrow-phone slider test, was failing on an error widget rather than layout.AppTracking.smallcaps(0.14em) is new, so the cue can ask for the smallcaps rule on the support rung, which does not default to it.AppTracking.tokenwas written and then deleted —count(0.06)landed onmainmid-branch and the drawer uses that.showAppSheetgained aneyebrow, because the design sets How to play over the drawer's title. One caller today; the design's other one is the duel's SHARE TO, unbuilt.if (card.fill).Registered rather than ported
Three, all in §11: the drawer ships without its per-kind icon well (marks exist for seven of ten kinds, and seven filled beside three empty is the fault #436 already ruled out); the cue line is taller than the design's, because Flutter cannot reproduce the button's
margin: '-13px -8px'bleed without shrinking the 44 target to 28×18; andmatch's cue says drag to pair where the app's board only taps.Off-token values
Two, each quoting the design: the drawer's
gap: 11between steps and itsmarginTop: 20over them.Checks
flutter analyze,dart format, the metrics gate, the comment cap and the changelog gate all clean; the full suite passes.