feat: Help answers its four questions, and the fine print gets one home - #591
Merged
Conversation
This was referenced Sep 10, 2026
4 tasks
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #531. Advances #448, which stays open for its one owner step.
Help's FAQ is built, and three of its four answers are re-grounded rather than ported — the design describes a different product. Terms, Privacy and the support mailbox become three constants every surface reads, so they go live together the moment they exist.
lib/core/config/app_links.dartis now the one file to open for any address the app points at:AppLinksfor what it owns and claims on the web,SupportLinksfor what someone must create first.Watch for
freeLessonIdsand the free-games rule, as the ticket names.closeglyph rotated 45°, because that mark is already the symmetric cross the turn ends on — one stroke weight, not two drawings of the same lines. Path's accordion keepsCaretMarkuntil that unified component lands.monetization/plus_offering, which missed every import ofplus_offering_provider— so any file could read the pricing arm through the provider without tripping it. Nowplus_offering, falsified against the new file.320mswas written five times with no token; this change would have been the fifth, soAppMotion.expandnow holds it and Path, Tour and the match card point at it.url_launcheris a new dependency, and the only thing that opens anything.AppLinksmoved fromcore/constants/tocore/config/, joining the three new constants. Same values, same universal-link claim; four existing call sites follow the import.Not here
PlusPitchListalready does.Checks
Driven on the simulator and read against the design; the first rendering was a wall of semicolons and was rewritten. Both reviews' findings are fixed in
804b47abandb54adf49.The derivation is falsified rather than asserted: adding a benefit to the offer changes the answer, and removing the guard's new allow-list entry fails it.