Skip to content

Feat(UI)-Fixed the issue with busses being upside down#92

Open
john-yang-11 wants to merge 6 commits intomaizebus-3from
busimagefix
Open

Feat(UI)-Fixed the issue with busses being upside down#92
john-yang-11 wants to merge 6 commits intomaizebus-3from
busimagefix

Conversation

@john-yang-11
Copy link
Copy Markdown

@john-yang-11 john-yang-11 commented Apr 18, 2026

Description

(1-2 sentences: New button to favorites sheet and now saving buildings)

Type of Change

  • New feature (feat)
  • Bug fix (fix)
  • Refactor / code improvement
  • Dependency / build update
  • Documentation
  • Other (explain)

Related Issues

Closes #XX

Changes Made

  • Flutter:
    • lib/screens/map_screen.dart
  • Backend (TypeScript):
    • ...
  • Firebase / Shared:
    • ...

Testing Done

Flutter:

  • Tested on:
    • iOS Simulator
    • Android Emulator
    • Physical device

Screenshots / Demo (if UI or notification change)

Checklist

  • Commit messages follow Conventional Commits
  • PR title follows [type](scope): short description
  • PR target branch is not main and is our current working update branch (e.g. maizebus2.1)
  • No print() / debugPrint() / console.log() left in production code
  • Secrets / keys not committed

@john-yang-11 john-yang-11 changed the base branch from main to maizebus-3 April 18, 2026 21:59
Copy link
Copy Markdown
Contributor

@iswheeler iswheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, just loaded the branch in VSCode and it looks like the bus icons aren't being rendered properly in the Android emulator. Could you please do some more testing?

Image

I also noticed you made lots of changes to favorite_building_storage.dart, building_sheet.dart, and favorites_sheet.dart. Would you mind explaining those in your PR please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants