-
Notifications
You must be signed in to change notification settings - Fork 9
Ace 79642664 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
promanik
wants to merge
370
commits into
mcarlson:master
Choose a base branch
from
teem2:ace_79642664
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ace 79642664 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs/index_orig.html. The hash argument of the url is used to select the page to display. The page contains both the description (as a comment) and code. I'm not sure if using # is the right thing because it makes it a little hard to switch to another page (if you edit the browser url). Lesson files are in /docs/din10/*.lzx. default.lzx is the default lesson and is shown if the specified page does not exist.
…ty. I left the Execute Button on the page for now. Added Prev/Next buttons to navigate to other examples in the lesson. The 5 examples are initially the same.
…tuff up, make more methods chainable.
…ndow.DREEM_INITED flag
…t the width and height include padding, borders, etc
…, eg.g for methods - see bugs/error2.html
…ents that need to be fired
[Fixes #79042844] setting box-sizing to border-box for sprites so that t...
…low timeout to be specified on the command line
It looks like my change to allow comments inside blocks addresses this, see 07caede 063d9b [Delivers #79004182]
[Delivers #79556166]
… are automatically sized to the size of their text to account for padding, now that box-sizing is border-box on views
…Timer. This reduces errors on Windows when exceptions are thrown. Sometimes, the first time I run phantomrunner.js I see errors like: RESOURCE ERROR: Operation canceled, URL: http://127.0.0.1:8080/classes/text.dre, File: error77941122.html These disappear if I run the test a second time.
This allows smoke/interactive/error79559324.html to work correctly. [Delivers #79559324]
[Delivers #79559324] for real
…ax for the text. I also moved the comments outside the class to prevent it from becoming part of the text. Also added smoke test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.