Follow-up to #2402, should complete #2305#2418
Merged
willend merged 1 commit intomccode-dev:mainfrom Apr 27, 2026
Merged
Conversation
1) Put #ifndef OPENACC around atan in tinyexpr.c since atan is not directly available (should idealy be mapped to atan(x)=atan2(x,1.0), will write issue to put in mccode-r) 2) Use GPU-compatible str_comp rather than strcmp in TRACE of the instr (There is a define for this that seems to not cover (all of) TRACE, should also go in mccode-r or cogen)
Contributor
Author
|
Tested functional for openacc on my office workstation with NVIDIA T600 GPU |
Contributor
Author
|
At the moment no idea why https://github.com/mccode-dev/McCode/actions/runs/25010441977/job/73244474549?pr=2418 is failing. |
Contributor
Author
|
Failing windows-test is non-conda mingw-gcc with mpi only: Corresponding conda-based is just fine: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Follow-up to #2402, should complete #2305
#ifndef OPENACCaround atan in tinyexpr.c sinceatanis not directly available(should idealy be mapped to
atan(x)=atan2(x,1.0), will write issue to put inmccode-r)str_comprather thanstrcmpinTRACEof the instr(There is a define for this that seems to not cover (all of)
TRACE, should also go inmccode-rorcogen)Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
OpenACC / Linux with NVIDIA GPU
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My PR is meant to fix a specific, existing issue
My contribution contains something else