-
Notifications
You must be signed in to change notification settings - Fork 5
docs: add Asgardeo for the tutorials #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Asgardeo-specific instructions to the existing Whoami and Todo Manager tutorials, guiding users through Asgardeo configuration for user info retrieval, client registration, API resources, scopes, and RBAC.
- Added new
<TabItem value="asgardeo">sections in both tutorials for Asgardeo integration. - Included step-by-step guides for client registration, scope configuration, and role setup in the Asgardeo Console.
- Updated links and notes to reflect Asgardeo’s signup and console URLs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| docs/tutorials/whoami/README.mdx | Inserted Asgardeo tabs for userinfo endpoint and client setup. |
| docs/tutorials/todo-manager/README.mdx | Added Asgardeo sections for API resource/scopes config and client registration. |
Comments suppressed due to low confidence (1)
docs/tutorials/whoami/README.mdx:70
- [nitpick] Indentation on this closing
</TabItem>has an extra leading space. Align it with other closing tags for consistency.
</TabItem>
3525a59 to
a79dcce
Compare
ab2eca8 to
0676356
Compare
|
Hi @VivekVinushanth , I just rebased your branch with the latest codes.
|
Hi @xiaoyijun apologies for the delay in responding. Have addressed the comments. Can you please check and let me know how I can be of help to get this added to your documents ? |
|
@xiaoyijun a gentle reminder on this. |
|
Hi @VivekVinushanth, currently, merging is blocked because the commits are missing GPG signatures (verified signature). |
# This is the 1st commit message: docs: merge upstream # This is the commit message mcp-auth#2: docs: address comments
fa7e76d to
9301a46
Compare
3887ebf to
36ed787
Compare
36ed787 to
1935e46
Compare
|
Hi @VivekVinushanth , thank you for the update! I’ve reviewed the changes, and currently the structure doesn’t fully align with our tutorial framework.
To ensure a smooth and consistent experience for users, we’d like the Asgardeo instructions to follow the same structure and flow as the rest of the tutorial. You might want to refer to the Logto example as a guide for reorganizing the content. Please feel free to reach out if you have any questions. |
|
Hi @xiaoyijun will check on this |
|
Hi @xiaoyijun added the necessary content. Can you please let me know if that make sense? |
|
@xiaoyijun A kind reminder on this |
|
Sincere apologies for bugging again @xiaoyijun. If there is anything needed from our end please let us know so that we can shape this document. Thanks and regards, |
|
Hi @xiaoyijun a kind reminder on this. Thanks in advance for your time! |
|
Hi @pavinduLakshan @VivekVinushanth , Sorry for the delay—I’ve been busy with a lot of things recently and haven’t had time to go through and test your tutorial yet. Thanks so much for your patience and for the reminders. I’ll do my best to check it out in the next few days. Thanks again for your understanding! |
|
I noticed that many steps in the tutorial mention creating an application. Is there a way to optimize the process into more progressive, step-by-step instructions? |
@xiaoyijun we truely appreciat your time and efforts. Thanks a lot. Please note that only https://github.com/mcp-auth/docs/pull/40/files#diff-8943d0a44b2b2db5374e0c209460918b21acd6aac00d4d84c43ebfc7a2644793R728 talks about creating an application. https://github.com/mcp-auth/docs/pull/40/files#diff-8943d0a44b2b2db5374e0c209460918b21acd6aac00d4d84c43ebfc7a2644793R336 section refers how to attach api-resources to the application created. In Asgardeo , API resources has to be added to the created application. |
|
A kind reminder on this @xiaoyijun |
Add Asgardeo-specific guide for configuring API resources, scopes, and RBAC to support tutorials.