chore(memory): promote strong-fit infrastructure drafts from memory-pipeline for review - #121
chore(memory): promote strong-fit infrastructure drafts from memory-pipeline for review#121Hareet wants to merge 4 commits into
Conversation
551acb2 to
e90aef1
Compare
|
Needs to be rebased with main after #119 is merged |
|
Heads up, this one currently has merge conflicts with its base and will need a rebase before it can merge. |
1979c05 to
6a2742a
Compare
sugat009
left a comment
sugat009
left a comment
There was a problem hiding this comment.
Content review. The operational core (Docker/Helm/HAProxy/CouchDB/upgrade tooling) is a strong, principled fit and the prose is faithful (verified 10006, 10267, 10557). Blockers:
- issue (blocking): identity keys record the PR number on 21 of 49 drafts (verified against
closingIssuesReferences); plus10689and8693close no tracked issue, so theirissueUrlpoints at the PR itself. - issue (blocking): 2 duplicate clusters (4 files): issue 10481 = [10482, 10488] (10488 is a 5.0.x cherry-pick), issue 9992 = [10006, 10267]. Separately,
9960and10014are near-duplicate content (both bump CouchDB to 3.5.0) for different issues. - issue (content):
10267misattributes an issue. Its "## Related Issues" describes #9992 as "line wrapping in HAProxy config", but issue #9992 is actually "Remove haproxy-healthcheck service from single-node deployments". - issue:
related_issues: []empty on every draft;domainFit: strongon every draft. Forced picks:10689(net-newadmin-tool/Angular app),10837/10857(CI supply-chain + credential-scanner security, all.github/+scripts/ci),10264(admin-app UI). Borderline:10045(mixed admin UI + upgrade service). - nitpick: classifier/seed reasoning leaks into
## Domain Rationaleon ~9 drafts (10512, 10557, 10758, 9119, 9634, 9700, 9717, 11141, 10264): "per the seeds", "the data-sync carve-out", etc.
Clean bill: no secrets, no PII, schema 100% valid.
| category: bug | ||
| domain: infrastructure | ||
| domainFit: strong | ||
| issueNumber: 10267 |
There was a problem hiding this comment.
issue: the "## Related Issues" section says #9992: line wrapping in HAProxy config..., but issue #9992 is "Remove haproxy-healthcheck service from single-node CouchDb deployments". The PR closes no tracked issue; this misdescribes the linked issue.
| category: bug | ||
| domain: infrastructure | ||
| domainFit: strong | ||
| issueNumber: 10488 |
There was a problem hiding this comment.
issue: this is a 5.0.x cherry-pick of #10482 (same helm change) written as a novel fix. It omits the Recreate-strategy change and misstates the template edits as a version-string cascade. Duplicate of 10482.
| category: feature | ||
| domain: infrastructure | ||
| domainFit: strong | ||
| issueNumber: 10689 |
There was a problem hiding this comment.
issue (domain-fit): net-new admin-tool Angular application (all files under admin-tool/); it closes no issue, so issueUrl points at the PR. Infrastructure is a least-bad bin for an app foundation.
…ly, infrastructure) Deterministic relink via #129's relink-issues tool: drafts whose identity keys recorded the merge PR now point at the resolved issue. Frontmatter id/issueNumber/issueUrl lines only; bodies untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Per sugat009's review on #121: collapse the #10481 cluster (10482 + 5.0.x cherry-pick 10488) preferring the canonical's Recreate-strategy account; fold 10267 into the #9992 canonical as a second source PR — verification showed it is a genuine follow-up (base64 no-wrap fix to the exact haproxy health config PR #10006 introduced), which also resolves the misattributed Related Issues text. Drop the three drafts whose PRs close no tracked issue (10689 app skeleton, 8693 k8s/helm templates, 8996 helm-repo — the third found by this pass) per the skip-and-flag policy. Suspect 10557 verified correct as stored: its PR body closes #10610; the filename token 10383 is a stale title scope for a different, still-open issue. The 9960/10014 CouchDB-3.5.0 near-dup pair verified as distinct work (Nouveau-inclusive vs couch-only, same day) — both kept, cross-linked via related_issues. Also: honest domainFit: weak on the forced picks (10837, 10857 CI security; 10264 admin UI), related_issues backfill (CouchDB pair + nouveau family), classifier-seed and reviewer-narrative scrubs across 25 files, and the optional source_prs schema definition. All 44 mappings verified against the live cht-core API (0 mismatches); validate-schema 108/108; no duplicate issueNumbers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
89d3473 to
33810f5
Compare
|
@sugat009 A few caveats on infrastructure domain, but let's get this thru:
|
Companion to the forms (#122) seeder's cross-domain dedup: the curated forms-and-reports memory for issue #10443 (default training forms missing from Docker images) lives on main and now records PR #10445 in its source_prs, so the duplicate draft here is removed. validate-schema 107/107; no duplicate issueNumbers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sugat009
left a comment
sugat009
left a comment
There was a problem hiding this comment.
Content re-review (post-rework). Identity/dedup are clean. Remaining:
- nitpick (leakage):
11162,9953,8794Domain Rationale carry classifier scaffolding ("per the CI/Docker pitfall", "Per the classification seeds", "…seed example") — strip; this class of cleanup is tracked by #136/#138. - (For the record: I initially flagged
8996's removal but withdrew it — the helm-repo migration is superseded, chart is now in-repo atscripts/build/helm, so dropping it is correct.)
Cross-cutting (whole promote batch, not blocking this PR alone): filenames still encode the PR number while frontmatter is issue-keyed, and two draft schemas coexist (machine-distilled vs hand-authored) — worth a cleanup pass. Full detail + re-runnable Verify commands are in my consolidated review notes.
2 participants
Promotes 49 strong-fit
infrastructuredrafts fromagent-memory/_pending/intoagent-memory/domains/infrastructure/issues/for squad content review.Categories: bug (22), feature (14), improvement (13)
Themes: HAProxy/CouchDB deployment & upgrades, Helm/Kubernetes charts, Nouveau sidecar, Docker images, CI/security scanning.
All 49 carry
domainFit: strong+ a## Domain Rationalesection. (infrastructureis a new domain introduced by #119's schema; 1 weak draft deferred to Stream C.)seeding-claude-cli-v2(feat(#108): seeding pipeline - CLI provider, domain-rationale, infrastructure domain, concurrency #119) — retarget tomainafter the schema lands.validate-schema: passing, 0 failures.