Improvements

[cod378]

Hi @meehow ,
Im cod378, and i'm happy to contribute to this fun & util project 💯

New feature: Play on background

• By default, the app continues working at close the window
• If you close de app when there is no playing, the app completly close (like before)
• Option in the menu to disable this behaviour
• Translations updated

Please watch the file in "docs/changes.md" to more detailded list of changes.

I hope your approval soon 😅

Best regards 🎉

[meehow]

Thanks for the contribution!
Few questions:

• Where is AGENTS.md file mentioned in the changelong?
• Do we really need third place to store changes? There is already Flathub and Debian changelog.
• Do we really need to add X11? Do we need to compile another binary to enable native X11?
• Do we really need "Run in background" feature? I usually just use minimize. Is it for saving ram or are there any other advantages of running in the background?

[cod378]

Hi @meehow ,
Thanks for your review. I'll answer your questions below:

• My mistake, I omitted the AGENTS.md file, I can add it without any problem.
• You're right, I can move the changelog to the existing files.
• Respect to X11, in summary, that related code is so that when the window is restored, it will be positioned in the same location it was in before it was hidden ...to better explain, the following answer is generated by an AI:

No, you don't need a separate binary or to add X11 explicitly. The code uses #if X11, which is a compile-time preprocessor directive, not a runtime check. The same binary includes or excludes the functionality based on whether libX11 is present at build time.
The dependency in meson.build is marked required: false:
x11_dep = dependency('x11', required: false)
if x11_dep.found()
  add_project_arguments('--define=X11', '--pkg', 'gtk4-x11', '--pkg', 'x11', language: 'vala')
endif
This means:
- If the GNOME 49 SDK includes libX11-dev → the binary gets position save/restore (useful on XWayland)
- If it doesn't → it still compiles fine, just without that feature (the compositor handles positioning, which is the default behavior)
For the Flatpak this is especially reasonable because window positioning on Wayland is managed by the compositor, not the app. The position feature only makes practical sense under pure X11 sessions.

• Do we really need "Run in background" feature?
  Absolutly yes :)
  In fact, the only reason I wasn't using your app was precisely because it didn't have that feature. I'm very used to it, since it's a feature present in the most popular music apps, like Spotify and YouTube Music (I'm sure I'm not the only one). I like that the music app disappears from the status bar or dock when I click "x"... but it's a personal preference, just like you might prefer that event to close the app completely :)
  ...if you'd like, we can leave the original "x" behavior as the default for closing the app, and users who prefer it can check the box in the menu to keep it running in the background.

I look forward to your reply.

[cod378]

Hi @meehow , Thanks for your review. I'll answer your questions below:

* My mistake, I omitted the AGENTS.md file, I can add it without any problem.

* You're right, I can move the changelog to the existing files.

* Respect to X11, in summary, that related code is so that when the window is restored, it will be positioned in the same location it was in before it was hidden ...to better explain, the following answer is generated by an AI:

No, you don't need a separate binary or to add X11 explicitly. The code uses #if X11, which is a compile-time preprocessor directive, not a runtime check. The same binary includes or excludes the functionality based on whether libX11 is present at build time.
The dependency in meson.build is marked required: false:
x11_dep = dependency('x11', required: false)
if x11_dep.found()
  add_project_arguments('--define=X11', '--pkg', 'gtk4-x11', '--pkg', 'x11', language: 'vala')
endif
This means:
- If the GNOME 49 SDK includes libX11-dev → the binary gets position save/restore (useful on XWayland)
- If it doesn't → it still compiles fine, just without that feature (the compositor handles positioning, which is the default behavior)
For the Flatpak this is especially reasonable because window positioning on Wayland is managed by the compositor, not the app. The position feature only makes practical sense under pure X11 sessions.

* Do we really need "Run in background" feature?
  Absolutly yes :)
  In fact, the only reason I wasn't using your app was precisely because it didn't have that feature. I'm very used to it, since it's a feature present in the most popular music apps, like Spotify and YouTube Music (I'm sure I'm not the only one). I like that the music app disappears from the status bar or dock when I click "x"... but it's a personal preference, just like you might prefer that event to close the app completely :)
  ...if you'd like, we can leave the original "x" behavior as the default for closing the app, and users who prefer it can check the box in the menu to keep it running in the background.

I look forward to your reply.

Hi @meehow ,
I'm waiting for your comments :)

Best regards

[cod378]

...zZz
...it seems you don't want them to touch your project, if that's the case, just say so.