Add "(MQTT)" in nodes after node name when appropriate#697
Closed
lachesis wants to merge 2 commits intomeshtastic:masterfrom
Closed
Add "(MQTT)" in nodes after node name when appropriate#697lachesis wants to merge 2 commits intomeshtastic:masterfrom
lachesis wants to merge 2 commits intomeshtastic:masterfrom
Conversation
|
|
Contributor
|
I'm sorry to get to this so slowly. I don't like modifying the name that's returned; while that works for the apps, I think we should retain the values from the node. That being said, once #736 is merged, it should be possible to tell the CLI to add another column for the via-MQTT flag, which I think is ultimately better. I'm going to close this for now, and hopefully that other PR can be suitable to merge soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches what the Android app does.