Skip to content

Refactor the Meshtastic TCP pub/sub example to ensure proper resource cleanup and clearer exception handling. #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dim5x wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor the Meshtastic TCP pub/sub example to ensure proper resource cleanup and clearer exception handling. #899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions examples/pub_sub_example2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@
import sys
import time

from pubsub import pub
from meshtastic.tcp_interface import TCPInterface

import meshtastic
import meshtastic.tcp_interface
from pubsub import pub

# simple arg check
if len(sys.argv) < 2:
Expand All @@ -29,11 +28,15 @@ def onConnection(interface, topic=pub.AUTO_TOPIC): # pylint: disable=unused-arg

pub.subscribe(onReceive, "meshtastic.receive")
pub.subscribe(onConnection, "meshtastic.connection.established")

iface=None
try:
iface = meshtastic.tcp_interface.TCPInterface(hostname=sys.argv[1])
iface = TCPInterface(hostname=sys.argv[1])
while True:
time.sleep(1000)
iface.close()
except Exception as ex:
print(f"Error: Could not connect to {sys.argv[1]} {ex}")
sys.exit(1)
raise
finally:
if iface:
iface.close()