Skip to content

Conversation

@ConnorHack
Copy link
Contributor

What does this PR do?

Updates CI/CD testing to the schedule workflow job for PRs, manual dispatch, and cron jobs.

  • PRs previously would not update the Workflow summary page with the test summary. They would only update the test summary on the PR itself as a comment. This fixes it so the test-summary is displayed as a PR comment AND GHA summary.
  • Cron jobs were scheduled, but did not include any tests. This fixes that.
  • Manual dispatch step variants have been updated to include 'schedule' jobs.

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 27, 2025
run:
shell: bash # default shell to run all steps for a given job.
runs-on: ${{ inputs.runner != '' && inputs.runner || 'llama-models-gha-runner-cpu' }}
runs-on: ${{ inputs.runner != '' && inputs.runner || github.repository_owner == 'meta-llama' && 'llama-models-gha-runner-cpu' || 'llama-models-fork-gha-runner-cpu' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you comment what these substrings mean? why "fork"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our self-hosted runners are initially set up using Cloud Terraform code. Each runner has distinct attributes, including:

  • A generic label for the runner
  • A specific repository URL

When testing from a fork, a separate runner is required to run independently of the main runner. This is because the forked repository URL differs from the main repository URL, and each runner can only point to one repository.

I adjusted this line so it automatically determines what name to use based on if the repository owner is meta-llama. If it is, then we use the default runner for the main repository. If not, then we use the runner that targets the fork.

Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@ConnorHack
Copy link
Contributor Author

@ashwinb anything else needed to ship this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants