Skip to content

Update model.py #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update model.py #372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2ba027
Update model.py
jeremylaratro Dec 24, 2024
59efe45
Added comments to briefly explain the addition per review request.
jeremylaratro Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions llama/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ class ModelArgs:

max_batch_size: int = 32
max_seq_len: int = 2048
use_scaled_rope: bool = True
# use_scaled_rope parameter is set to default 'True'
# Note: scaled rope parameters are defined in params.json and referenced in model.py,
# but no actual scaling logic has been implemented yet. This placeholder allows the 3.1 model to run
# without breaking until scaled rope is implemented.


class RMSNorm(torch.nn.Module):
Expand Down