Add frame rate to VideoEncoder API #1054
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds output
frame_rateto the API.Previously, we always encoded videos using the same
frame_rateas the inputframes.Now, we can set the output
frame_ratewhen callingto_file/to_tensor/to_filelike(as inAudioEncoder), to adjusts the encoded video's frame durations. If no outputframe_rateis specified, fallback to reusing the inputframe_rate.Testing:
To test, I added
test_frame_rate_parameterwhich slows and speeds up a test video and ensures the video metadata is updated correctly. I also observed the video plays back slower or faster.API after changes:
The complete API now looks as follows: