_init_dist() removal #561
Merged
_init_dist() removal #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2025 10:35
The _init_dist() method was setting up PyTorch distributed environment variables manually. This is no longer needed because the provisioner's get_proc_mesh() method now properly calls setup_env_for_distributed() from Monarch, which handles all distributed environment setup. This simplifies the code and removes redundant initialization.
Previously the method was just commented out. This commit fully removes it since the provisioner now handles all distributed environment setup via setup_env_for_distributed(). This makes the code cleaner and easier to maintain.
meta-cla
bot
added
the
CLA Signed
allenwang28
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _init_dist() method was setting up PyTorch distributed environment
variables manually. This is no longer needed because the provisioner's
get_proc_mesh() method now properly calls setup_env_for_distributed()
from Monarch, which handles all distributed environment setup. This simplifies the code and removes redundant initialization.