Skip to content

Conversation

@casteryh
Copy link
Contributor

Summary:
Fixes wandb complaining about metadata being None.

tested by running
python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml

Differential Revision: D87092141

Summary:
Fixes wandb complaining about metadata being None.

tested by running
python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml

Differential Revision: D87092141
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 14, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 14, 2025

@casteryh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87092141.

Co-authored-by: Felipe Mello <[email protected]>
@meta-codesync
Copy link

meta-codesync bot commented Nov 14, 2025

@casteryh has imported this pull request. If you are a Meta employee, you can view this in D87092141.

Copy link
Contributor

@felipemello1 felipemello1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test not passing :(

Only src/forge/__init__.py was intended to be changed.
@casteryh
Copy link
Contributor Author

unit test not passing :(

it's passing on my local machine... I will move this snippet to the init of logger and see if it works

@casteryh casteryh merged commit 6e77f0b into main Nov 16, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants