Add new metrics for operators #458
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the op_gflops, op_gbytes and grid_size metrics to the addmm operator Signed-off-by: Bryan Bowyer <[email protected]>
xuzhao9
approved these changes
Sep 19, 2025
bdbowyer
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
bdbowyer
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
xuzhao9
reviewed
Oct 24, 2025
| def op_gflops( | ||
| self, fn_name: str, example_inputs: Any, metrics: BenchmarkOperatorMetrics | ||
| ) -> float: | ||
| """Report the raw number of GFLOPS (not GFLOPS/sec) for the addmm operation.""" |
Contributor
There was a problem hiding this comment.
This seems to be redundant to the flops() metric?
| self, fn_name: str, example_inputs: Any, metrics: BenchmarkOperatorMetrics | ||
| ) -> float: | ||
| """Report the raw number of gigabytes of I/O (not GB/sec) for the addmm operation.""" | ||
| a, mat1, mat2 = example_inputs |
Contributor
There was a problem hiding this comment.
We can directly call self.flops(fn_name, example_inputs, metrics) to get the flops, then multiply it by a.element_size().
xuzhao9
reviewed
Oct 24, 2025
Contributor
xuzhao9
left a comment
xuzhao9
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Sorry that I somehow missed reviewing this.
Can you help address the inline comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the op_gflops, op_gbytes and grid_size metrics to the addmm operator as proposed new metrics. If these metrics are acceptable, I can raise PRs to add metrics for the other operators.