Skip to content

🌱 Use IRSO in e2e tests #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adilGhaffarDev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Use IRSO in e2e tests #2776

adilGhaffarDev wants to merge 1 commit into from
+642 −853

Conversation

@adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Sep 11, 2025

What this PR does / why we need it:
Use IRSO in e2e tests
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Sep 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2025
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2025
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2025
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 12, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main

1 similar comment
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 16, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 16, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 16, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 16, 2025

/test metal3-centos-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2025
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Nov 14, 2025

/test metal3-ubuntu-e2e-integration-test-main

tuminoid
tuminoid reviewed Nov 16, 2025
View reviewed changes
@tuminoid tuminoid requested a review from Copilot November 16, 2025 15:33
Copilot finished reviewing on behalf of tuminoid November 16, 2025 15:35
Copilot AI reviewed Nov 16, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 40 out of 40 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Nov 17, 2025

/test metal3-centos-e2e-integration-test-main
/test metal3-e2e-clusterctl-upgrade-test-main

tuminoid
tuminoid reviewed Nov 18, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the indents, otherwise this is looking good.

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Nov 19, 2025

Fix the indents, otherwise this is looking good.

done

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Nov 19, 2025

/test metal3-centos-e2e-integration-test-main

2 similar comments
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Nov 19, 2025

/test metal3-centos-e2e-integration-test-main

@kashifest
Copy link
Member

kashifest commented Nov 24, 2025

/test metal3-centos-e2e-integration-test-main

@kashifest
Copy link
Member

kashifest commented Nov 24, 2025

Round 1 passed: IPA downloaded in less than 3 minutes

100 499M 100 499M 0 0 3763k 0 0:02:15 0:02:15 --:--:-- 4205k
https://jenkins.nordix.org/view/Metal3/job/metal3-centos-e2e-integration-test-main/1949/

@kashifest
Copy link
Member

kashifest commented Nov 24, 2025

/test metal3-centos-e2e-integration-test-main

1 similar comment
@kashifest
Copy link
Member

kashifest commented Nov 25, 2025

/test metal3-centos-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2025
@adilGhaffarDev adilGhaffarDev mentioned this pull request Dec 1, 2025
Open
@adilGhaffarDev
Use IRSO in e2e tests
19dc53d 
Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2025
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 3, 2025

/test metal3-centos-e2e-integration-test-main

2 similar comments
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 3, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 3, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 4, 2025

passed twice in a row, I will run few more times
/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 6, 2025

/test metal3-centos-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2025
@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Dec 6, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments

Copilot code review Copilot Copilot left review comments

@honza honza Awaiting requested review from honza

@Rozzii Rozzii Awaiting requested review from Rozzii

@nuhakala nuhakala Awaiting requested review from nuhakala

Assignees

No one assigned

Labels

needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adilGhaffarDev @metal3-io-bot @Rozzii @kashifest @tuminoid @nuhakala