Modifications to ForecastTrajectoryGapFiller#2369
Draft
gavinevans wants to merge 4 commits into
Draft
Conversation
gavinevans
force-pushed
the
mobt_783_temporal_interpolation
branch
from
d4a7391 to
8b2f876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/metoppv/mo-blue-team/issues/783
Description
This PR makes some edits to the ForecastTrajectoryGapFiller, mainly for the aim of being able to interpolate accumulation fields, like instantaneous fields e.g. interpolating a T+3 1 hour precipitation accumulation field, from a fields at T+2 and T+4, without an assumption that the interpolation is actually an attempt to disaggregate an accumulation field e.g. disaggregating a 3 hour precipitation accumulation field into 1 hour precipitation accumulation field.
This PR therefore provides a pathway through the ForecastTrajectoryGapFiller (and TemporalInterpolation) plugins for accumulation field interpolation, modifies bounds handling of the accumulation fields, and converts quite a lot of time-based processing in the ForecastTrajectoryGapFiller to use seconds to consistency with the coordinates being handled.
Testing: