Skip to content

Mobt1161 precip phase decision tree#2376

Merged
mo-jbeaver merged 5 commits into
metoppv:masterfrom
mo-jbeaver:mobt1161_precip_phase_decision_tree
May 15, 2026
Merged

Mobt1161 precip phase decision tree#2376
mo-jbeaver merged 5 commits into
metoppv:masterfrom
mo-jbeaver:mobt1161_precip_phase_decision_tree

Conversation

@mo-jbeaver
Copy link
Copy Markdown
Contributor

Addresses: https://github.com/metoppv/mo-blue-team/issues/1161

Builds on the changes made in previous PR: #2375
Additional changes made to the decision_tree.py and unit tests added.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

Copy link
Copy Markdown
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mo-jbeaver 👍

I've added very minor comments.

Comment thread improver/categorical/decision_tree.py Outdated
Comment thread improver_tests/categorical/decision_tree/test_ApplyDecisionTree.py Outdated
Comment thread improver_tests/categorical/decision_tree/test_ApplyDecisionTree.py Outdated
Copy link
Copy Markdown
Contributor

@brhooper brhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mo-jbeaver, I've added one comment but it's related to follow-on work so I'm happy to approve this.

Comment thread improver/categorical/decision_tree.py
@mo-jbeaver mo-jbeaver merged commit e6477e7 into metoppv:master May 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants