Do not add tags with phys cam name in multi cam #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These "tags" contain device label + key + value. The code deleted here was setting the keys CameraChannelIndex/Name under the device label of the physical camera (as opposed to the multi-camera device itself). There is no code in MMCoreJ, MMStudio, plugins, and acquisition engines (including pymmcore-plus) that ever reads these tags, so remove them entirely. Aside from being a red herring when trying to understand tag usage, there was no correct way to add/remove tags at start and stop of sequence acquisition, because application code is not technically required to call stopSequenceAcquisition() after a finite sequence acquisition. (In the case of ArduinoCounter and CameraPulser, the equivalent code was already missing from one of the 2 overloads of StartSequenceAcquisition.) There was no code calling RemoveTag() for these tags. Multi Camera, ArduinoCounter, and CameraPulser still retain code that sets CameraChannelIndex/Name under its own device label; this is done when the physical cameras are set and remains unchanged here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #773.
These "tags" contain device label + key + value.
The code deleted here was setting the keys CameraChannelIndex/Name under the device label of the physical camera (as opposed to the multi-camera device itself). There is no code in MMCoreJ, MMStudio, plugins, and acquisition engines (including pymmcore-plus) that ever reads these tags, so remove them entirely.
Aside from being a red herring when trying to understand tag usage, there was no correct way to add/remove tags at start and stop of sequence acquisition, because application code is not technically required to call stopSequenceAcquisition() after a finite sequence acquisition.
(In the case of ArduinoCounter and CameraPulser, the equivalent code was already missing from one of the 2 overloads of
StartSequenceAcquisition.)
There was no code calling RemoveTag() for these tags.
Multi Camera, ArduinoCounter, and CameraPulser still retain code that sets CameraChannelIndex/Name under its own device label; this is done when the physical cameras are set and remains unchanged here.