Partial changes for issue 5819 #5838

insightworks007 · 2025-12-15T19:38:01Z

Replaced with PR 6046 #6046

Summary

In short - using this pattern risks silent failures, which can introduce inconsistencies or other bugs when used as part of a larger process. To answer your question, we do use it also, but only in cases where we are 100% sure that it will not cause other issues or in some test setups. If that is the case, then ok, otherwise, would be better to remove the pattern.

QltyGenerationRuleMgmt.Codeunit.al 227,60: if TemporaryTestMatchRecordRef.Insert(false) then;
Analysis: This did exist because a failure here was inconsequential to the remaining process.
Resolution: I've removed the pattern.
265,79: if TempAlreadySearchedsQltyInspectSourceConfig.Insert() then;
Analysis: This was here as a safety mechanism to avoid a failure with a repeated insert from a chained configuration, however there is another safety above it with the get(). A failure is inconsequential to the workflow, however the earlier safety should prevent the problem.
Resolution: I've removed the pattern.
314,56: if TempQltyInTestGenerationRule.Insert() then;
Analysis: This is there to help avoid duplicate buffer records. A failed insert here should not fail the usage.
Resolution: I've kept this.
QltyInTestGenerationRule.Table.al 319,27: if Rec.Insert() then;
Analysis: This was here to help workaround a timing issue in BC with the feature of validating a field causing a record insert/modify if fast data entry occurs while a record is being added. Some initial testing with BC27 shows this doesn't seem to occur anymore. A failure is inconsequential to the workflow.
Resolution: I've removed this.
QltyInTestGeneratRules.Page.al 663,56: if QltyInTestGenerationRule.Modify() then;
Analysis: This was to help work with fast data entry that no longer seems to be an issue. A failure is inconsequential to the workflow.
Resolution: I've removed this.
QltyGradeEvaluation.Codeunit.al 262,64: if OptionalQltyInspectionTestHeader.Modify(true) then;
Analysis: A failure here is inconsequential to workflow, but does not appear to be necessary.
Resolution: I've removed this.
551,60: if TempNumericalQltyInspectionTestLine.Insert(false) then;
Analysis: This is used with a buffer record where a failed insert must not cause a failure on the calling method.
Resolution: I've kept this.
702,48: if TempTestStringValueQltyField.Insert() then;
Analysis: This change already appears to have been done in the main branch, or it otherwise doesn't appear to exist in the 'main' branch of the public version of the repo.
Resolution: No change made, appears to already have been done or otherwise not in the public repo.
QltyTraversal.Codeunit.al 217,52: if TemporaryTestMatchRecordRef.Insert(false) then;
Analysis: This is in ApplySourceFields, where the source record details are copied to a buffer record to allow copying. A failure of the insert must not cause a failure upstream.
Resolution: No change made.
QltyField.Table.al 527,60: if TempBufferQltyLookupCode.Insert() then;
Analysis: This was a safety to prevent human entered duplicates.
Resolution: I've changed the safety approach to Get() on the buffer record first intead.
QltyFieldExprCardPart.Page.al 505,33: if QltyField.Insert() then;
Analysis: This does not appear to exist in the 'main' branch on the public repo.
Resolution: Either this change was already made elsewhere, or is otherwise not in the public repo.
QltyFieldNumberCardPart.Page.al 1040,33: if QltyField.Insert() then;
Analysis: This does not appear to exist in the 'main' branch on the public repo.
Resolution: Either this change was already made elsewhere, or is otherwise not in the public repo.
QltyFieldWizard.Page.al 348,49: if QltyField.Delete() then;
Analysis: A failure here should not cause a problem and is ideally silent for the workflow of the wizard closing the page.
Resolution: I've left this.
QltyLookupCodePart.Page.al 406,37: if QltyField.Modify(true) then;
Analysis: Based on code history on the full version that this code is derived from this appears to be another workaround for timing issues when the modify-on-field-change feature was initially implemented in BC. I cannot reproduce the original issue in the latest BC 27, so I've removed this workaround as it no longer seems necessary as far as I can tell.
Resolution: I've removed this code.
506,33: if QltyField.Insert() then;
Analysis: This does not appear to exist in the 'main' branch on the public repo.
Resolution: Either this change was already made elsewhere, or is otherwise not in the public repo.
QltyDispMoveWorksheet.Codeunit.al 169,49: if TempCreatedsWhseWorksheetLine.Insert() then;
Analysis: This is a safety condition. TempCreatedWhseWorksheetLine should be cleared in PerformDisposition, and prior to the buffer being inserted it is based on a newly created worksheet line. In a perfect scenario there wouldn't be an error. However, an error should also not stop the flow since it's effectively just used to filter the lines that end up getting used to create a movement document.
Resolution: I've left this, it's more important in this scenario to not error and in the unlikely event of a duplicate buffer record an error building the buffer should not stop the objective of a movement document being made.
QltyDispPurchaseReturn.Codeunit.al 156,51: if TempCreatedBufferPurchaseHeader.Insert() then;
Analysis: This is a safety, where a failed buffer insert should not be stopping the creation of a purchase return header. The safety could be done differently.
Resolution: I've changed the safety approach.
QltyDispInternalPutAway.Codeunit.al 151,43: if WhseInternalPutAwayLine.Modify() then;
Analysis: This is a safety, but doesn't appear necessary.
Resolution: I've removed this.
QltyInspectionTestHeader.Table.al 350,40: if Rec.Modify(false) then;
Analysis: This is a safety, but doesn't appear necessary.
Resolution: I've removed this.
356,44: if Rec.Modify(false) then;
Analysis: This is a safety, but doesn't appear necessary.
Resolution: I've removed this.
1191,31: if Rec.Modify() then;
Analysis: This should not be here, a failure in the modify when changing the lot should cause a failure to the user.
Resolution: I've removed this.
1255,31: if Rec.Modify() then;
Analysis: This should not be here, a failure in the modify as the package is changed should cause a failure to the user.
Resolution: I've removed this.
1315,31: if Rec.Modify() then;
Analysis: This should not be here, a failure in the modify as the package is changed should cause a failure to the user.
Resolution: I've removed this.
QltyProdGenRuleWizard.Page.al 815,44: if QltyManagementSetup.Modify(false) then;
Analysis: This was intended to help configurators that were allowed to change the rules but not necessarily the setup, which is an unnecessary flow in the foundation version.
Resolution: I've removed this.
QltyProductionIntegration.Codeunit.al 405,49: if QltyInspectionTestHeader.Modify(false) then;
Analysis: This is here because the source document information not updating is not critical path especially with how it's triggered (such as a prod order changing to finished status). (An error here preventing a finish is worse than an error here stopping the transaction, finishing a prod order is important, updating an information field is not as important).
Resolution: I've left this, however the feature of updating the source details may not be necessary at all for foundation.
425,49: if QltyInspectionTestHeader.Modify(false) then;
Same as above.
445,49: if QltyInspectionTestHeader.Modify(false) then;
Same as above.
QltyRecGenRuleWizard.Page.al 927,44: if QltyManagementSetup.Modify(false) then;
Analysis: This was intended to help configurators that were allowed to change the rules but not necessarily the setup, which is an unnecessary flow in the foundation version.
Resolution: I've removed this.
QltyWarehouseIntegration.Codeunit.al 67,50: if TempTrackingSpecification.Insert(false) then;
Analysis: This was just a safety for the buffer record.
Resolution: I've removed this.
157,56: if TempOutTrackingSpecification.Insert() then;
Analysis: This does not appear to exist in the 'main' branch on the public repo.
Resolution: Either this change was already made elsewhere, or is otherwise not in the public repo.
QltyWhseGenRuleWizard.Page.al 681,44: if QltyManagementSetup.Modify(false) then;
Analysis: This was intended to help configurators that were allowed to change the rules but not necessarily the setup, which is an unnecessary flow in the foundation version.
Resolution: I've removed this.
QltyInventoryAvailability.Codeunit.al 78,54: if TempOutBinContent.Insert(false) then;
97,54: if TempOutBinContent.Insert(false) then;
Analysis: This does not appear to exist in the 'main' branch on the public repo.
Resolution: Either this change was already made elsewhere, or is otherwise not in the public repo.
QltyReportSelection.Page.al 94,27: if Rec.Modify() then;
Analysis: This appears to be a workaround for a timing issue.
Resolution: A different safety has been added instead.
QltyInspectionActivities.Page.al 65,27: if Rec.Insert() then;
Analysis: This is to prevent an error where if someone uses the role center but doesn't have permission to insert the cue record it will prevent the role center from crashing.
Resolution: I've kept this.
QltyMiscHelpers.Codeunit.al 296,56: if TempBufferQltyLookupCode.Insert() then;
Analysis: This is to help prevent an error for an inconsequential setup issue, for example if someone configures the field to look up values that are not unique, this can help prevent an error. i.e A,B,A in the source data, the expected result would be A,B.
It looks like there is another safety checker for this same scenario with DuplicateChecker.
Resolution: I've removed this.
QltyNotificationMgmt.Codeunit.al 406,52: if QltyInspectionTestHeader.Modify() then;
Analysis: A failure here should probably fail to the user.
Resolution: I've removed this.

Work Item(s)

Fixes #5819 (AB#611285)

…es (microsoft#5967) Navigate to Results list from Result Code Add missing Drill Down for Inspection Lines Fixes: - [AB#615771](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615771) - [AB#617015](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617015)

…ties. Extra changes. (microsoft#5991) This PR contains minor changes required to adding new demo data for PA: - Fixing preparation of the temporary buffer before doing historical matching, specifically for allocation account. The reason is that the name of the allocation account is different from what we have in the purchase invoice lines after splitting the allocation account to G/L accounts. - Fixing sample purchase invoice functionality by populating the description on the lines - Adding new countries to demodata app.json [AB#579972](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/579972/)

…icrosoft#5932) Improving inbound e-document page: - Show task id for the inbound e-document and open the task pane when user click the field - Show both confirmed and extracted vendors - Change first fields on the inbound e-documents page based on the UX review Side: Add missing sorting for using statements to pass the build Fixes [AB#607925](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/607925)

#### Summary  #### Work Item(s)  Fixes [AB#614168](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/614168)

Reverting unnecessary change to the inbound e-documents page that make the Import PDF action visible Fixes [AB#579972](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/579972)

…y Order Lines (microsoft#5964) ### Summary Enhanced the Shopify Order Subform page to automatically set the Unit of Measure Code when an Item is selected on an order line. ### Changes **File:** ShpfyOrderSubform.Page.al - Added `OnValidate` trigger to the "Item No." field that automatically populates the "Unit of Measure Code" based on the selected item: - If the item has a "Sales Unit of Measure" defined, it uses that value - Otherwise, it falls back to the item's "Base Unit of Measure" ### Motivation When users manually map Shopify order lines to Business Central items, they previously had to manually enter the Unit of Measure Code. This change improves the user experience by automatically defaulting the UoM based on the item's configuration, reducing manual data entry and potential errors. #### Work Item(s)  Fixes [AB#617019](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617019)

…5963) ## Add Data Capture support for Fulfillment Orders ### Summary This PR adds Data Capture functionality for Fulfillment Orders, mirroring the existing implementation for Order Fulfillments. This allows users to view the raw JSON data retrieved from Shopify for debugging and troubleshooting purposes. ### Changes #### Pages - **ShpfyFulfillmentOrderCard.Page.al**: Added "Retrieved Shopify Data" action with `actionref` in the promoted area to view captured data for the selected fulfillment order - **ShpfyFulFillmentOrders.Page.al**: Added the same "Retrieved Shopify Data" action to the list page for quick access from the list view #### Table - **ShpfyFulFillmentOrderHeader.Table.al**: Extended `OnDelete` trigger to clean up associated Data Capture records when a fulfillment order header is deleted #### Codeunit - **ShpfyFulfillmentOrdersAPI.Codeunit.al**: - Added `DataCapture.Add()` call in `ExtractFulfillmentOrder` to save the fulfillment order JSON response - Added `DataCapture.Add()` call in `ExtractFulfillmentOrderLines` to save the fulfillment order lines JSON response #### Work Item(s)  Fixes [AB#616999](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616999)

### Summary This PR adds extensibility for Shopify product metafields, allowing external developers to programmatically manage metafields through a public facade codeunit and integration events. ### Problem External developers cannot programmatically: - Retrieve metafield definitions for products/variants - Add metafields with values when missing - Force-sync metafields to Shopify outside of the standard item sync ### Solution Implemented a public facade pattern (similar to existing `Shpfy Product` and `Shpfy Orders` codeunits) for metafield management. ### Changes - **ShpfyMetafields.Codeunit.al** - Public facade codeunit with: - `GetMetafieldDefinitions(ParentTableNo, OwnerId, ShopCode)` - Retrieve metafield definitions from Shopify - `SyncMetafieldToShopify(Metafield, ShopCode): BigInteger` - Sync a single metafield to Shopify - `SyncMetafieldsToShopify(ParentTableNo, OwnerId, ShopCode)` - Sync all metafields for a resource - **ShpfyProductEvents.Codeunit.al** - Added `OnBeforeUpdateProductMetafields(ProductId: BigInteger)` integration event - **ShpfyProductExport.Codeunit.al** - Raises `OnBeforeUpdateProductMetafields` event before syncing metafields - Refactored to use public facade for metafield operations - **ShpfyMetafields.Page.al** - Added "Sync to Shopify" action with multi-select support - Refactored to use public facade for all metafield operations - **ShpfyCustomerExport.Codeunit.al** - Refactored to use public facade for metafield sync - **ShpfyCompanyExport.Codeunit.al** - Refactored to use public facade for metafield sync #### Work Item(s)  Fixes [AB#617035](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617035)

…rkflows in the external-dependencies group across 1 directory (microsoft#5891) Bumps the external-dependencies group with 1 update in the /.github/workflows directory: [step-security/harden-runner](https://github.com/step-security/harden-runner). Updates `step-security/harden-runner` from 2.13.3 to 2.14.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/step-security/harden-runner/releases">step-security/harden-runner's releases</a>.</em></p> <blockquote> <h2>v2.14.0</h2> <h2>What's Changed</h2> <ul> <li>Selective installation: Harden-Runner now skips installation on GitHub-hosted runners when the repository has a custom property skip_harden_runner, allowing organizations to opt out specific repos.</li> <li>Avoid double install: The action no longer installs Harden-Runner if it’s already present on a GitHub-hosted runner, which could happen when a composite action also installs it.</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/step-security/harden-runner/compare/v2.13.3...v2.14.0">https://github.com/step-security/harden-runner/compare/v2.13.3...v2.14.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/step-security/harden-runner/commit/20cf305ff2072d973412fa9b1e3a4f227bda3c76"><code>20cf305</code></a> Merge pull request <a href="https://redirect.github.com/step-security/harden-runner/issues/622">#622</a> from step-security/feature/custom-property-skip</li> <li><a href="https://github.com/step-security/harden-runner/commit/c51e8eeb6c4fdcd08f65e43a051dacdbfaa69702"><code>c51e8ee</code></a> feat: skip agent install and post step on subsequent runs for GitHub-hosted r...</li> <li><a href="https://github.com/step-security/harden-runner/commit/e152b90204c3d85cefa1441b701a47a13ed28bd7"><code>e152b90</code></a> feat: skip harden-runner based on repository custom property</li> <li><a href="https://github.com/step-security/harden-runner/commit/ee1faec052d1000061fa79a13e030db11b3f86bd"><code>ee1faec</code></a> feat: replace skip-harden-runner with skip-on-custom-property input</li> <li><a href="https://github.com/step-security/harden-runner/commit/1dc7c1764659d537dab2a854b8e165a801103eb1"><code>1dc7c17</code></a> feat: add skip-harden-runner input to conditionally skip execution</li> <li>See full diff in <a href="https://github.com/step-security/harden-runner/compare/df199fb7be9f65074067a9eb93f12bb4c5547cf2...20cf305ff2072d973412fa9b1e3a4f227bda3c76">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=step-security/harden-runner&package-manager=github_actions&previous-version=2.13.3&new-version=2.14.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…microsoft#6012)  #### Summary  #### Work Item(s)  Fixes [AB#615833](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615833)

…ry for ".." entry (microsoft#5894)  #### Summary  Issue: When using the folder selection dialog, if a user navigates into a directory and then selects the ".." (back/parent) entry and clicks OK, the function returns an invalid path containing the literal ".." segment (e.g., Docs/mine/2025/../). Fix: Added a check to detect when the ".." navigation entry is selected and return the current directory path directly instead of combining it with the ".." literal. #### Work Item(s)  Fixes microsoft#5893 Fixes [AB#616797](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616797) --------- Co-authored-by: Tine Staric <[email protected]>

Resolved merge conflicts in: src/Apps/W1/Quality Management/app/src/Configuration/GenerationRule/QltyInspecGenRuleMgmt.Codeunit.al src/Apps/W1/Quality Management/app/src/Configuration/GenerationRule/QltyInspectionGenRule.Table.al src/Apps/W1/Quality Management/app/src/Configuration/GenerationRule/QltyInspectionGenRules.Page.al src/Apps/W1/Quality Management/app/src/Configuration/Grade/QltyGradeEvaluation.Codeunit.al src/Apps/W1/Quality Management/app/src/Configuration/Template/Test/QltyLookupCodePart.Page.al src/Apps/W1/Quality Management/app/src/Document/QltyInspectionHeader.Table.al src/Apps/W1/Quality Management/app/src/Integration/Manufacturing/QltyProdGenRuleWizard.Page.al src/Apps/W1/Quality Management/app/src/Integration/Receiving/QltyRecGenRuleWizard.Page.al src/Apps/W1/Quality Management/app/src/Utilities/QltyNotificationMgmt.Codeunit.al

The merge-base changed after approval.

insightworks007 · 2026-01-08T14:00:52Z

PR 5838 is replaced with PR #6046 to handle the recent object renames.

Partial changes for issue 5819

0619af8

insightworks007 requested a review from a team as a code owner December 15, 2025 19:38

github-actions bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Dec 15, 2025

PredragMaricic previously approved these changes Dec 16, 2025

View reviewed changes

PredragMaricic requested review from JakovljevicDusan and tomasevicst December 16, 2025 12:59

tomasevicst previously approved these changes Dec 16, 2025

View reviewed changes

JesperSchulz added the SCM GitHub request for SCM area label Dec 17, 2025

github-actions bot added the Linked Issue is linked to a Azure Boards work item label Dec 17, 2025

github-actions bot added this to the Version 28.0 milestone Dec 17, 2025

insightworks007 closed this Dec 23, 2025

ChethanT reopened this Dec 23, 2025

ChethanT enabled auto-merge (squash) December 23, 2025 14:12

JakovljevicDusan and others added 13 commits December 26, 2025 10:56

Revert incorrect change for inbound e-document page (microsoft#6014)

7a08ca0

Reverting unnecessary change to the inbound e-documents page that make the Import PDF action visible Fixes [AB#579972](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/579972)

Resolved merge conflicts after main branch object renames

df1f395

auto-merge was automatically disabled January 5, 2026 20:58
Head branch was pushed to by a user without write access

insightworks007 dismissed stale reviews from tomasevicst and PredragMaricic via df1f395 January 5, 2026 20:58

insightworks007 requested review from a team as code owners January 5, 2026 20:58

github-actions bot added Build: Automation Workflows and other setup in .github folder AL: System Application labels Jan 5, 2026

PredragMaricic previously approved these changes Jan 6, 2026

View reviewed changes

insightworks007 closed this Jan 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Partial changes for issue 5819 #5838

Partial changes for issue 5819 #5838

Uh oh!

insightworks007 commented Dec 15, 2025 •

edited

Loading

Uh oh!

insightworks007 commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Partial changes for issue 5819 #5838

Partial changes for issue 5819 #5838

Uh oh!

Conversation

insightworks007 commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Work Item(s)

Uh oh!

insightworks007 commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

insightworks007 commented Dec 15, 2025 •

edited

Loading