Resolve snmalloc zero memory issue #2211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
reviewed
Feb 19, 2021
achamayou
approved these changes
Feb 19, 2021
Co-authored-by: Amaury Chamayou <[email protected]>
|
fix_mem_issue@19176 aka 20210219.5 vs main ewma over 20 builds from 18776 to 19166 |
Contributor
Author
|
Ignore daily build failure, this will be fixed in #2210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snmalloc which we use in virtual mode added a test configuration in which it zeros out memory in the POSIX PAL. It is turned off in Release mode and was meant to be used in the snmalloc CI. What happened with CCF is that we primarily run in RelWithDebInfo and setting was not turned off in this configuration.
Matt is going to look into fixing this in the snmalloc repo but for us this is a quick fix by adding a setting to the cmake.