-
Notifications
You must be signed in to change notification settings - Fork 243
[Ignore] Pack tests #7448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Ignore] Pack tests #7448
Conversation
|
Really strange failure, with the schema endpoint returning an empty body: https://github.com/microsoft/CCF/actions/runs/19175402504/job/54911735292?pr=7448 |
|
This is caused by the GOV_API_SCHEMA_2023_06_01_PREVIEW cmake var being expanded in api_schema.h.in. The test failing is comparing the contents of the file to what is returned by In a build with a clean cmake cache, GOV_API_SCHEMA_2023_06_01_PREVIEW is empty, and so the endpoint legitimately returns an empty body. I am restoring the cmake variable for now, and will PR a separate removal of 2023-06-01-preview, or at least its deprecation for 7.x (depending on the usage situation). |
|
|
Fresh start on remaining parts of #7417 to pack the tests more efficiently.
Those steps have been tested successfully so far: