Update ExperimentalNop tests, add instructions for release shader model update #7994
+8
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note, when reviewing the test changes, it might be slightly confusing because the rename matching is (understandably) misfiring. It says: But it's really: Because I updated 1.8/6.8 metadata to 1.9/6.9 for the update in latest release version. |
V-FEXrt
reviewed
Dec 9, 2025
V-FEXrt
approved these changes
Dec 9, 2025
V-FEXrt
approved these changes
Dec 10, 2025
…d only create a conflict.
tex3d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Released shader model was updated recently, along with a change to one of the tests for ExperimentalNop.
However, a test update went against the intent of the test. As this test would require an unusual situation where there are two experimental shader model versions above release supported, and as it tests already-well-tested common opcode version checking infrastructure, it didn't really seem necessary, so I've removed that test.
I also added instructions for the next release shader model change.