Skip to content

Conversation

@hpdic
Copy link

@hpdic hpdic commented Dec 15, 2025

  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Should this result in any changes to our documentation, either updating existing docs or adding new ones?

Reference Issues/PRs

What does this implement/fix? Briefly explain your changes.

This PR fixes a logical error in IndexConfigBuilder::build() where a safety check logic was duplicated, causing the logging code to become unreachable dead code. A couple of minor things: missing some header includes; string check is redundant.

Previously, there were two identical if (_dynamic_index && _num_frozen_pts == 0) checks.

The first check silently set _num_frozen_pts = 1.

The second check (which contained the warning log) would effectively become if (true && 1 == 0), which always evaluates to false.

As a result, the warning message "_num_frozen_pts passed as 0 ..." would never be printed.

The fix: I removed the first redundant check. Now the code correctly logs the warning before overriding the value to 1.

I also fixed a few other minor things like missing header includes and string checks.

Any other comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant