Add a retry when performing on-demand summary #25977
Merged
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian-thompson
requested review from
a team,
MarioJGMsoft,
WillieHabi,
jason-ha,
jatgarg,
markfields and
steffenloesch
steffenloesch
approved these changes
Dec 4, 2025
Contributor
steffenloesch
left a comment
steffenloesch
left a comment
There was a problem hiding this comment.
Looks good to me. Left a nit feedback on comments.
| * Returns success/failure and an optional error for host-side handling. | ||
| * | ||
| * @legacy @alpha | ||
| */ |
Contributor
There was a problem hiding this comment.
Nit: it would be good to mention the retry in the doc comment too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a race condition around when snapshots become available for a summarizer. During catching up, a Container may see that it has a new snapshot it should load from. If so, it will attempt to load this new snapshot and close the container. See ContainerRuntime.fetchLatestSnapshotAndMaybeClose.
For normal summarizer cases, this is fine as the summarizer will simply be recreated based on the latest snapshot. But for the on-demand flow, this may be unexpected behavior from the consumer's perspective. So, we should attempt a retry in the event that this is the reason the first on-demand attempt failed.
This was caught via e2e tests against ODSP and FRS consistently failing.
AB#50569
AB#50568