-
Notifications
You must be signed in to change notification settings - Fork 280
Remove third party libraries #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bmehta001
wants to merge
37
commits into
main
Choose a base branch
from
bhamehta/remove-third-party-libs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
f8d86b0
Remove third-party OpenAI libraries from C# and Rust SDKs
bmehta001 92331ac
Update C# samples and docs to use new SDK types
bmehta001 2b5106c
Revert enums to strings for Role, Type, and FinishReason
bmehta001 94282ad
Fix CI failures and address Copilot review comments
bmehta001 afa77f8
Merge branch 'main' into bhamehta/remove-third-party-libs
bmehta001 20976e9
Add C# enums matching official .NET OpenAI SDK patterns; add Invalid …
bmehta001 1c42d9e
Apply code formatting across C# SDK and Rust SDK
bmehta001 2589fb0
Update docs and merge AudioTranscriptionRequest classes
bmehta001 9cfa428
Fix stale API docs for ChatClient, AudioClient, and LiveAudioTranscri…
bmehta001 dbc5583
Revert unrelated formatting changes to non-SDK files
bmehta001 1d73650
Remove stale Id field from LiveAudioTranscriptionResponse table in C#…
bmehta001 039fc85
Rename extension classes for clarity
bmehta001 976d9fb
Restore 'apply our specific settings' comment in AudioTranscriptionEx…
bmehta001 fa30c80
Update Rust api.md re-exported types to match actual exports
bmehta001 8a7c84d
Address PR review: nullable Role for streaming deltas, robust ToolCho…
bmehta001 b70bfcd
Add FunctionCall to C# FinishReason enum to match Rust and official O…
bmehta001 b179f97
Add max_completion_tokens to Rust, Python, and JS SDKs (closes #576)
bmehta001 4192909
Fix Rust clippy: remove useless String-to-String conversions
bmehta001 5c677d6
Simplify Rust SDK: derive Serialize for settings, deduplicate From impls
bmehta001 3f3efb8
Add refusal property to C# ChatMessage for cross-SDK parity
bmehta001 b087f62
Make ToolCall.Index and AudioTranscriptionResponse.Duration nullable
bmehta001 2d3f659
Rust review fixes: replace unwrap with expect, restore pub(crate) on …
bmehta001 e666360
Clarify AudioTranscriptionRequest comment about PascalCase convention
bmehta001 4289c9c
Add Developer role to ChatMessageRole in C# and Rust SDKs
bmehta001 26f3406
Rename internal extension files for clarity
bmehta001 3708b9b
Add token usage details and logprobs to C# and Rust SDKs
bmehta001 de24f58
Remove forward-compat fields not yet emitted by Core
bmehta001 20dc2aa
Remove refusal from C# and Rust SDKs — Core doesn't emit it
bmehta001 f2613ab
Fix PR review comments: wire format alignment and null safety
bmehta001 3fa1101
Remove redundant readonly modifiers from auto-properties
bmehta001 78a964f
Align ToolChoice with official OpenAI .NET SDK patterns
bmehta001 e775fb7
Merge branch 'main' into bhamehta/remove-third-party-libs
bmehta001 c5dd389
Rename FinishReason -> ChatFinishReason, ToolType -> ChatToolKind
bmehta001 f4b80ab
Rename CreatedAtUnix -> Created, ToolCall.FunctionCall -> ToolCall.Fu…
bmehta001 3da3272
Revert ChatFinishReason/ChatToolKind to wire-aligned FinishReason/Too…
bmehta001 51828db
Add cross-SDK integration tests for type array tool parameters (#576)
bmehta001 ac2168e
Revert "Add cross-SDK integration tests for type array tool parameter…
bmehta001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| // <complete_code> | ||
| // <complete_code> | ||
| using Microsoft.AI.Foundry.Local; | ||
| using OpenAI; | ||
| using OpenAI.Chat; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.