Skip to content

feat(acp): add CodeBuddy to the built-in external agent catalogue - #144

Merged
Luna Qiu (lunaqiu) merged 1 commit into
microsoft:mainfrom
lunaqiu:feat/codebuddy-acp-agent
Sep 5, 2026
Merged

feat(acp): add CodeBuddy to the built-in external agent catalogue#144
Luna Qiu (lunaqiu) merged 1 commit into
microsoft:mainfrom
lunaqiu:feat/codebuddy-acp-agent

Conversation

@lunaqiu

Copy link
Copy Markdown
Collaborator

What

Adds Tencent Cloud's CodeBuddy Code CLI to the trusted built-in catalogue of ACP-capable external agents, so it appears as a first-class option in Settings → External Agents → Add agent instead of requiring a Custom command.

Why

CodeBuddy speaks ACP natively via codebuddy --acp — the same shape as Gemini and Qwen Code — so it fits the existing catalogue with no new machinery. known-agents.ts is deliberately a pure data module, separate from the host probing logic in agent-cli-detect.ts, which means adding an agent is a data-only change.

How

Field Value Rationale
binary codebuddy Native ACP support; no adapter binary needed
acpArgs ['--acp'] Documented ACP entry point
autoApprove null See below
skipVersionProbe (omitted) codebuddy --version prints 2.137.1 and exits in ~170 ms, well inside the 2.5 s probe timeout

autoApprove is null on purpose. CodeBuddy Code is architecturally derived from Claude Code (identical slash-command surface: /agents, /bashes, /compact, …) and likewise delegates tool-permission decisions to ACP requests. There is no documented blanket auto-approve argument scoped to --acp mode, and the catalogue's contract is that only official argument-based recipes are encoded here. --dangerously-skip-permissions exists for -p batch mode but is not documented for the ACP path, so encoding it would be a guess.

Changes

  • apps/server/src/modules/agent/acp/known-agents.ts — new codebuddy entry
  • apps/server/src/modules/agent/acp/known-agents.test.ts — expectations updated
  • docs/architecture/agent-architecture.md — catalogue list updated
  • apps/docs/src/sections/ai/ExternalAgents.tsx — user-facing list updated, count nine → ten

Testing

  • pnpm --filter @huabu/server test -- acp — 15 files / 113 tests passing
  • pnpm --filter @huabu/server typecheck, pnpm --filter @huabu/docs typecheck — clean
  • ESLint on all touched files — clean
  • Manually verified in a local dev build (CodeBuddy Code 2.137.1): the agent is detected, a Profile can be created, and a conversation runs against a Space

Notes for reviewers

No changes to detection, launch, or connection logic — this is a data-only addition to the catalogue plus the documentation that mirrors it.

Tencent Cloud's CodeBuddy Code CLI speaks ACP natively via 'codebuddy --acp',
so it slots into the existing known-agents data catalogue like Gemini/Qwen
Code rather than needing an adapter. Its permission model mirrors Claude
Code (the architecture it is built on), so autoApprove is null pending an
official argument-based full-auto recipe for --acp mode.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The catalogue, tests, and documentation are consistent, with no unresolved issues.

Pull request overview

Adds CodeBuddy as a built-in ACP external agent.

Changes:

  • Adds the codebuddy --acp launch recipe.
  • Updates catalogue tests and documentation.
  • Updates the supported-agent count and installation link.
File summaries
File Description
docs/architecture/agent-architecture.md Adds CodeBuddy to the architecture catalogue.
apps/server/src/modules/agent/acp/known-agents.ts Defines the CodeBuddy catalogue entry.
apps/server/src/modules/agent/acp/known-agents.test.ts Verifies CodeBuddy’s command and approval configuration.
apps/docs/src/sections/ai/ExternalAgents.tsx Adds CodeBuddy and updates the agent count.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@lunaqiu
Luna Qiu (lunaqiu) marked this pull request as ready for review September 5, 2026 12:14
@lunaqiu
Luna Qiu (lunaqiu) merged commit a3c411e into microsoft:main Sep 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants