Skip to content

XS✔ ◾ Switching Platform to AnyCPU #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neilr81 wants to merge 9 commits into
base: main
Choose a base branch
from
Open

XS✔ ◾ Switching Platform to AnyCPU #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1d9e58c
Switching Platform to AnyCPU
May 27, 2025
29140e0
Testing PlatformTargets
Jun 4, 2025
4fac25c
Merge branch 'main' into feature/platform-anycpu
neilr81 Jun 9, 2025
6e20041
Switching to AnyCPU
Jun 20, 2025
1406bd1
Merge branch 'main' into feature/platform-anycpu
neilr81 Jun 20, 2025
b34bc73
Merge branch 'main' into feature/platform-anycpu
neilr81 Jul 11, 2025
f61c857
Merge branch 'main' into feature/platform-anycpu
neilr81 Aug 7, 2025
c03b2b7
Merge branch 'main' into feature/platform-anycpu
neilr81 Mar 10, 2026
b0d2c83
Merge branch 'main' into feature/platform-anycpu
neilr81 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
[Dd]ebugPublic/
[Rr]elease/
[Rr]eleases/
AnyCPU/
x64/
x86/
bld/
Expand Down
2 changes: 1 addition & 1 deletion ...lthChecks.AspNetCore/Microsoft.Omex.Extensions.Diagnostics.HealthChecks.AspNetCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(NetCoreVersions)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<PropertyGroup Label="NuGet Properties">
<Title>Microsoft.Omex.Extensions.Diagnostics.HealthChecks.AspNetCore</Title>
Expand Down
2 changes: 1 addition & 1 deletion src/Diagnostics.HealthChecks/Microsoft.Omex.Extensions.Diagnostics.HealthChecks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(NetCoreVersions)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<PropertyGroup Label="NuGet Properties">
<Title>Microsoft.Omex.Extensions.Diagnostics.HealthChecks</Title>
Expand Down
2 changes: 1 addition & 1 deletion src/Hosting.Services.Remoting/Microsoft.Omex.Extensions.Hosting.Services.Remoting.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(NetCoreVersions)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<PropertyGroup Label="NuGet Properties">
<Title>Microsoft.Omex.Extensions.Hosting.Services.Remoting</Title>
Expand Down
2 changes: 1 addition & 1 deletion src/Hosting.Services.Web/Microsoft.Omex.Extensions.Hosting.Services.Web.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(NetCoreVersions)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<PropertyGroup Label="NuGet Properties">
<Title>Microsoft.Omex.Extensions.Hosting.Services.Web</Title>
Expand Down
2 changes: 1 addition & 1 deletion src/Hosting.Services/Microsoft.Omex.Extensions.Hosting.Services.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(NetCoreVersions)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<PropertyGroup Label="NuGet Properties">
<Title>Microsoft.Omex.Extensions.Hosting.Services</Title>
Expand Down
2 changes: 1 addition & 1 deletion ...FabricGuest.Abstractions/Microsoft.Omex.Extensions.ServiceFabricGuest.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(NetCoreVersions)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget> to reference the shared value from Directory.Build.props.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>

<PropertyGroup Label="NuGet Properties">
Expand Down
2 changes: 1 addition & 1 deletion src/Services.Remoting/Microsoft.Omex.Extensions.Services.Remoting.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(NetCoreVersions)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 14 changed .csproj files use <PlatformTargets>$(Platforms)</PlatformTargets> (plural), but the correct MSBuild property to control the compiler's target architecture is <PlatformTarget> (singular). <PlatformTargets> is not a recognized SDK/MSBuild property and will be silently ignored at build time, meaning the platform constraint is effectively removed rather than explicitly set to AnyCPU. The intended replacement should be <PlatformTarget>AnyCPU</PlatformTarget> (or <PlatformTarget>$(Platforms)</PlatformTarget> to reference the shared property from Directory.Build.props).

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<PropertyGroup Label="NuGet Properties">
<Title>Microsoft.Omex.Extensions.Services.Remoting</Title>
Expand Down
2 changes: 1 addition & 1 deletion ....UnitTests/Microsoft.Omex.Extensions.Diagnostics.HealthChecks.AspNetCore.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFrameworks>$(UnitTestTargetFrameworks)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\src\Diagnostics.HealthChecks.AspNetCore\Microsoft.Omex.Extensions.Diagnostics.HealthChecks.AspNetCore.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion ...ealthChecks.UnitTests/Microsoft.Omex.Extensions.Diagnostics.HealthChecks.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(UnitTestTargetFrameworks)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\src\Diagnostics.HealthChecks\Microsoft.Omex.Extensions.Diagnostics.HealthChecks.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion ...s.Remoting.UnitTests/Microsoft.Omex.Extensions.Hosting.Services.Remoting.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFrameworks>$(UnitTestTargetFrameworks)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\src\Hosting.Services.Remoting\Microsoft.Omex.Extensions.Hosting.Services.Remoting.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion tests/Hosting.Services.UnitTests/Microsoft.Omex.Extensions.Hosting.Services.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(UnitTestTargetFrameworks)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.ServiceFabric.Actors" />
Expand Down
2 changes: 1 addition & 1 deletion ...ng.Services.Web.UnitTests/Microsoft.Omex.Extensions.Hosting.Services.Web.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(UnitTestTargetFrameworks)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\src\Hosting.Services.Web\Microsoft.Omex.Extensions.Hosting.Services.Web.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion ...ions.UnitTests/Microsoft.Omex.Extensions.ServiceFabricGuest.Abstractions.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(UnitTestTargetFrameworks)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\src\Hosting\Microsoft.Omex.Extensions.Hosting.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion .../Services.Remoting.UnitTests/Microsoft.Omex.Extensions.Services.Remoting.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(UnitTestTargetFrameworks)</TargetFrameworks>
<PlatformTarget>x64</PlatformTarget>
<PlatformTargets>$(Platforms)</PlatformTargets>
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PlatformTargets> (plural) is not a recognized MSBuild/SDK property — it will be silently ignored. The correct property to set the compiler's target architecture is <PlatformTarget> (singular). The fix should use <PlatformTarget>AnyCPU</PlatformTarget> or <PlatformTarget>$(Platforms)</PlatformTarget>.

Suggested change
<PlatformTargets>$(Platforms)</PlatformTargets>
<PlatformTarget>$(Platforms)</PlatformTarget>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.ServiceFabric.Actors" />
Expand Down
Loading